Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 9979004: Show an error if a field has no getter defined in a getter context (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporated feedback. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
index d40f3b7059096dac47ab5dad75d48cfdedb4b019..e45732bddb13accb17ba56f65998dfacd9963555 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java
@@ -1050,6 +1050,17 @@ public class Resolver {
onError(x.getName(), ResolverErrorCode.NOT_A_STATIC_FIELD,
x.getPropertyName());
}
+ if (Elements.inGetterContext(x)) {
+ if (field.getGetter() == null && field.getSetter() != null) {
+ onError(x.getName(), ResolverErrorCode.FIELD_DOES_NOT_HAVE_A_GETTER);
+ }
+ }
+ if (Elements.inSetterContext(x)) {
+ if (field.getSetter() == null && field.getGetter() != null) {
+ onError(x.getName(), ResolverErrorCode.FIELD_DOES_NOT_HAVE_A_SETTER);
+ }
+ }
+
break;
case NONE:

Powered by Google App Engine
This is Rietveld 408576698