Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 9979003: Ensure default isolate is present in Add/RemoveCallCompletedCallback. (Closed)

Created:
8 years, 8 months ago by danno
Modified:
8 years, 8 months ago
Reviewers:
ulan, Philippe
CC:
v8-dev
Visibility:
Public.

Description

Ensure default isolate is present in Add/RemoveCallCompletedCallback. R=ulan@chromium.org,pliard@chromium.org BUG=ui_tests don't crash in Chrome Committed: https://code.google.com/p/v8/source/detail?r=11225

Patch Set 1 #

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/api.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
8 years, 8 months ago (2012-04-04 14:19:24 UTC) #1
ulan
lgtm
8 years, 8 months ago (2012-04-04 14:21:19 UTC) #2
Philippe
8 years, 8 months ago (2012-04-04 14:35:18 UTC) #3
On 2012/04/04 14:21:19, ulan wrote:
> lgtm

lgtm. Thanks for the fix!

Powered by Google App Engine
This is Rietveld 408576698