Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/api.cc

Issue 9979003: Ensure default isolate is present in Add/RemoveCallCompletedCallback. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5261 matching lines...) Expand 10 before | Expand all | Expand 10 after
5272 void V8::RemoveMemoryAllocationCallback(MemoryAllocationCallback callback) { 5272 void V8::RemoveMemoryAllocationCallback(MemoryAllocationCallback callback) {
5273 i::Isolate* isolate = i::Isolate::Current(); 5273 i::Isolate* isolate = i::Isolate::Current();
5274 if (IsDeadCheck(isolate, "v8::V8::RemoveMemoryAllocationCallback()")) return; 5274 if (IsDeadCheck(isolate, "v8::V8::RemoveMemoryAllocationCallback()")) return;
5275 isolate->memory_allocator()->RemoveMemoryAllocationCallback( 5275 isolate->memory_allocator()->RemoveMemoryAllocationCallback(
5276 callback); 5276 callback);
5277 } 5277 }
5278 5278
5279 5279
5280 void V8::AddCallCompletedCallback(CallCompletedCallback callback) { 5280 void V8::AddCallCompletedCallback(CallCompletedCallback callback) {
5281 if (callback == NULL) return; 5281 if (callback == NULL) return;
5282 i::Isolate::EnsureDefaultIsolate();
5282 i::Isolate* isolate = i::Isolate::Current(); 5283 i::Isolate* isolate = i::Isolate::Current();
5283 if (IsDeadCheck(isolate, "v8::V8::AddLeaveScriptCallback()")) return; 5284 if (IsDeadCheck(isolate, "v8::V8::AddLeaveScriptCallback()")) return;
5284 i::V8::AddCallCompletedCallback(callback); 5285 i::V8::AddCallCompletedCallback(callback);
5285 } 5286 }
5286 5287
5287 5288
5288 void V8::RemoveCallCompletedCallback(CallCompletedCallback callback) { 5289 void V8::RemoveCallCompletedCallback(CallCompletedCallback callback) {
5290 i::Isolate::EnsureDefaultIsolate();
5289 i::Isolate* isolate = i::Isolate::Current(); 5291 i::Isolate* isolate = i::Isolate::Current();
5290 if (IsDeadCheck(isolate, "v8::V8::RemoveLeaveScriptCallback()")) return; 5292 if (IsDeadCheck(isolate, "v8::V8::RemoveLeaveScriptCallback()")) return;
5291 i::V8::RemoveCallCompletedCallback(callback); 5293 i::V8::RemoveCallCompletedCallback(callback);
5292 } 5294 }
5293 5295
5294 5296
5295 void V8::PauseProfiler() { 5297 void V8::PauseProfiler() {
5296 i::Isolate* isolate = i::Isolate::Current(); 5298 i::Isolate* isolate = i::Isolate::Current();
5297 isolate->logger()->PauseProfiler(); 5299 isolate->logger()->PauseProfiler();
5298 } 5300 }
(...skipping 1077 matching lines...) Expand 10 before | Expand all | Expand 10 after
6376 6378
6377 6379
6378 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) { 6380 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) {
6379 HandleScopeImplementer* scope_implementer = 6381 HandleScopeImplementer* scope_implementer =
6380 reinterpret_cast<HandleScopeImplementer*>(storage); 6382 reinterpret_cast<HandleScopeImplementer*>(storage);
6381 scope_implementer->IterateThis(v); 6383 scope_implementer->IterateThis(v);
6382 return storage + ArchiveSpacePerThread(); 6384 return storage + ArchiveSpacePerThread();
6383 } 6385 }
6384 6386
6385 } } // namespace v8::internal 6387 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698