Refactoring of chrome speech recognition architecture (CL1.6)

Refactoring of chrome speech recognition architecture (CL1.6)

Renamed caller_id -> session_id in speech recognition classes. This is a partial refactoring in preparation for next CLs.

BUG=116954
TEST=none.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132979

[Primiano Tucci (use gerrit), 2012-04-16 11:46:43]

https://chromiumcodereview.appspot.com/9972008/diff/23/content/browser/render...
File content/browser/renderer_host/render_process_host_impl.cc (left):

https://chromiumcodereview.appspot.com/9972008/diff/23/content/browser/render...
content/browser/renderer_host/render_process_host_impl.cc:504:
content::BrowserMainLoop::GetAudioManager()));
This is not tightly related with this CL. Just noted that after a "3'rd party"
CL we don't need this argument anymore.

https://chromiumcodereview.appspot.com/9972008/diff/23/content/public/browser...
File content/public/browser/speech_recognizer.h (left):

https://chromiumcodereview.appspot.com/9972008/diff/23/content/public/browser...
content/public/browser/speech_recognizer.h:28: // TODO(primiano) Create(...) is
transitional (until we fix speech input
Moved this comment to content/browser/speech/speech_recognizer_impl.cc. Is is
useless here since it is dominated by the upper TODO(primiano).

[Primiano Tucci (use gerrit), 2012-04-16 11:52:46]

Just a reminder for myself: wait for http://codereview.chromium.org/10071040/ to
land before committing this or patch will probably fail.

[hans, 2012-04-17 00:00:11]

lgtm

https://chromiumcodereview.appspot.com/9972008/diff/5005/content/browser/spee...
File content/browser/speech/speech_recognizer_impl.h (right):

https://chromiumcodereview.appspot.com/9972008/diff/5005/content/browser/spee...
content/browser/speech/speech_recognizer_impl.h:33: // Handles speech
recognition for a session (identified by |session_id|), taking
i like how the new variable name fits in with this comment :)

[jam, 2012-04-17 04:35:42]

content/public and content/browser/renderer_host lgtm

http://codereview.chromium.org/9972008/diff/5005/content/public/browser/speec...
File content/public/browser/speech_recognizer.h (left):

http://codereview.chromium.org/9972008/diff/5005/content/public/browser/speec...
content/public/browser/speech_recognizer.h:28: // TODO(primiano) Create(...) is
transitional (until we fix speech input
why take this comment out, are you not planning on doing this anymore?

[Primiano Tucci (use gerrit), 2012-04-17 09:21:47]

On 2012/04/17 04:35:42, John Abd-El-Malek wrote:
> content/public and content/browser/renderer_host lgtm
> 
>
http://codereview.chromium.org/9972008/diff/5005/content/public/browser/speec...
> File content/public/browser/speech_recognizer.h (left):
> 
>
http://codereview.chromium.org/9972008/diff/5005/content/public/browser/speec...
> content/public/browser/speech_recognizer.h:28: // TODO(primiano) Create(...)
is
> transitional (until we fix speech input
> why take this comment out, are you not planning on doing this anymore?

Oh no, it is still valid. I did also attach a comment to that line, but I guess
it has been hidden by the second patch set.
My comment was: "Moved this comment to
content/browser/speech/speech_recognizer_impl.cc. Is is
useless here since it is dominated by the upper TODO(primiano)."

[Satish, 2012-04-17 09:25:43]

lgtm

https://chromiumcodereview.appspot.com/9972008/diff/5005/chrome/browser/speec...
File chrome/browser/speech/speech_input_extension_manager.cc (right):

https://chromiumcodereview.appspot.com/9972008/diff/5005/chrome/browser/speec...
chrome/browser/speech/speech_input_extension_manager.cc:60: // TODO(primiano)
this will not be valid anymore once speech input extension
'valid anymore' -> 'required'
'extension will use' -> 'extension API uses'

[commit-bot: I haz the power, 2012-04-19 10:10:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/primiano@chromium.org/9972008/7002

[commit-bot: I haz the power, 2012-04-19 11:42:54]

Change committed as 132979