Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 9972002: Delete snapshots more than a day old. (Closed)

Created:
8 years, 8 months ago by grt (UTC plus 2)
Modified:
8 years, 8 months ago
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org, robertshield
Visibility:
Public.

Description

Delete snapshots more than a day old. This goes hand-in-hand with https://chromiumcodereview.appspot.com/10007043/, which will generate snapshots for Chrome Frame tests that time out. This gives diagnosticians a day to retrieve snapshots before they're reaped. In my dream world, the snapshots are uploaded somewhere and automatically linked to in the log for the test that timed out. The thought makes me giddy with excitement. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132593

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M scripts/slave/slave_utils.py View 1 2 3 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
grt (UTC plus 2)
8 years, 8 months ago (2012-04-14 23:07:22 UTC) #1
Marc-Antoine Ruel (Google)
lgtm with nits https://chromiumcodereview.appspot.com/9972002/diff/1/scripts/slave/slave_utils.py File scripts/slave/slave_utils.py (right): https://chromiumcodereview.appspot.com/9972002/diff/1/scripts/slave/slave_utils.py#newcode501 scripts/slave/slave_utils.py:501: old_snapshot = 'ChromiumSnapshot%04d%02d%02d%02d%02d%02d' % \ style ...
8 years, 8 months ago (2012-04-14 23:43:55 UTC) #2
grt (UTC plus 2)
PTAL https://chromiumcodereview.appspot.com/9972002/diff/1/scripts/slave/slave_utils.py File scripts/slave/slave_utils.py (right): https://chromiumcodereview.appspot.com/9972002/diff/1/scripts/slave/slave_utils.py#newcode501 scripts/slave/slave_utils.py:501: old_snapshot = 'ChromiumSnapshot%04d%02d%02d%02d%02d%02d' % \ On 2012/04/14 23:43:55, ...
8 years, 8 months ago (2012-04-17 17:17:24 UTC) #3
M-A Ruel
lgtm
8 years, 8 months ago (2012-04-17 17:20:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/9972002/4001
8 years, 8 months ago (2012-04-17 17:21:45 UTC) #5
commit-bot: I haz the power
Presubmit check for 9972002-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-17 17:24:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/9972002/9001
8 years, 8 months ago (2012-04-17 17:31:34 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 17:33:54 UTC) #8
Change committed as 132593

Powered by Google App Engine
This is Rietveld 408576698