Delete snapshots more than a day old.

Delete snapshots more than a day old.

This goes hand-in-hand with https://chromiumcodereview.appspot.com/10007043/, which will generate snapshots for Chrome Frame tests that time out.  This gives diagnosticians a day to retrieve snapshots before they're reaped.  In my dream world, the snapshots are uploaded somewhere and automatically linked to in the log for the test that timed out.  The thought makes me giddy with excitement.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132593

[Marc-Antoine Ruel (Google), 2012-04-14 23:43:55]

lgtm with nits

https://chromiumcodereview.appspot.com/9972002/diff/1/scripts/slave/slave_uti...
File scripts/slave/slave_utils.py (right):

https://chromiumcodereview.appspot.com/9972002/diff/1/scripts/slave/slave_uti...
scripts/slave/slave_utils.py:501: old_snapshot =
'ChromiumSnapshot%04d%02d%02d%02d%02d%02d' % \
style nit: I prefer () to \

also we don't put white space around parenthesis.
You could do:
old_snapshot = yesterday.strftime('ChromiumSnapshot%Y%m%d%H%M%S')

[grt (UTC plus 2), 2012-04-17 17:17:24]

PTAL

https://chromiumcodereview.appspot.com/9972002/diff/1/scripts/slave/slave_uti...
File scripts/slave/slave_utils.py (right):

https://chromiumcodereview.appspot.com/9972002/diff/1/scripts/slave/slave_uti...
scripts/slave/slave_utils.py:501: old_snapshot =
'ChromiumSnapshot%04d%02d%02d%02d%02d%02d' % \
On 2012/04/14 23:43:55, Marc-Antoine Ruel (Google) wrote:
> style nit: I prefer () to \
> 
> also we don't put white space around parenthesis.
> You could do:
> old_snapshot = yesterday.strftime('ChromiumSnapshot%Y%m%d%H%M%S')

Thanks, done.

[M-A Ruel, 2012-04-17 17:20:54]

lgtm

[commit-bot: I haz the power, 2012-04-17 17:21:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/9972002/4001

[commit-bot: I haz the power, 2012-04-17 17:24:16]

Presubmit check for 9972002-4001 failed and returned exit status 1.

Running presubmit commit checks ...
************* Module slave.slave_utils
W0622:496,23:RemoveOldSnapshots: Redefining built-in 'dir'

** Presubmit ERRORS **
Fix pylint errors first.

Presubmit checks took 149.7s to calculate.

[commit-bot: I haz the power, 2012-04-17 17:31:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/9972002/9001

[commit-bot: I haz the power, 2012-04-17 17:33:54]

Change committed as 132593