Delete snapshots more than a day old.

scripts/slave/slave_utils.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Functions specific to build slaves, shared by several buildbot scripts.
 """
 
+import datetime
+import glob
 import inspect
 import os
 import re
 import socket
 import sys
 import tempfile
 import time
 
 from common import chromium_utils
 from slave import xvfb
@@ skipping 466 matching lines @@
           os.remove(full_path)
         elif os.path.isdir(full_path):
           chromium_utils.RemoveDirectory(full_path)
         else:
           print "Temp item wasn't a file or directory?"
       except OSError, e:
         print >> sys.stderr, e
         # Don't fail.
 
 
+def RemoveOldSnapshots(dir):
+  """Removes ChromiumSnapshot files more than one day old. Such snapshots are
+  created when certain tests timeout (e.g., Chrome Frame integration tests)."""
+  # Compute the file prefix of a snapshot created one day ago.
+  yesterday = datetime.datetime.now() - datetime.timedelta(1)
+  old_snapshot = 'ChromiumSnapshot%04d%02d%02d%02d%02d%02d' % \

[Marc-Antoine Ruel (Google), 2012/04/14 23:43:55]

style nit: I prefer () to \

also we don't put white space around parenthesis.
You could do:
old_snapshot = yesterday.strftime('ChromiumSnapshot%Y%m%d%H%M%S')

[grt (UTC plus 2), 2012/04/17 17:17:24]

Thanks, done.

+      ( yesterday.year, yesterday.month, yesterday.day, yesterday.hour,
+        yesterday.minute, yesterday.second )
+  # Collect snapshots at least as old as that one created a day ago.
+  to_delete = []
+  for snapshot in glob.iglob(os.path.join(dir, 'ChromiumSnapshot*.png')):
+    if os.path.basename(snapshot) < old_snapshot:
+      to_delete.append(snapshot)
+  # Delete the collected snapshots.
+  for snapshot in to_delete:
+    print "Removing old snapshot: %s" % snapshot
+    try:
+      os.remove(snapshot)
+    except OSError, e:
+      print >> sys.stderr, e
+
+
 def RemoveChromeDesktopFiles():
   """Removes Chrome files (i.e. shortcuts) from the desktop of the current user.
   This does nothing if called on a non-Windows platform."""
   if chromium_utils.IsWindows():
     desktop_path = os.environ['USERPROFILE']
     desktop_path = os.path.join(desktop_path, 'Desktop')
     LogAndRemoveFiles(desktop_path, '^(Chromium|chrome) \(.+\)?\.lnk$')
+    RemoveOldSnapshots(desktop_path)
 
 
 def RemoveChromeTemporaryFiles():
   """A large hammer to nuke what could be leaked files from unittests or
   files left from a unittest that crashed, was killed, etc."""
   # NOTE: print out what is cleaned up so the bots don't timeout if
   # there is a lot to cleanup and also se we see the leaks in the
   # build logs.
   # At some point a leading dot got added, support with and without it.
   kLogRegex = '^\.?(com\.google\.Chrome|org\.chromium)\.'
@@ skipping 15 matching lines @@
       if ns_temp_dir:
         LogAndRemoveFiles(ns_temp_dir, kLogRegex)
     for i in ('Chromium', 'Google Chrome'):
       # Remove dumps.
       crash_path = '%s/Library/Application Support/%s/Crash Reports' % (
           os.environ['HOME'], i)
       LogAndRemoveFiles(crash_path, r'^.+\.dmp$')
   else:
     raise NotImplementedError(
         'Platform "%s" is not currently supported.' % sys.platform)