Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9969208: TabContents -> WebContentsImpl, part 20. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
jam, marja
CC:
chromium-reviews, ncarter (slow), creis+watch_chromium.org, akalin, Raghu Simha, ajwong+watch_chromium.org, Avi (use Gerrit), dcheng, marja+watch_chromium.org, brettw-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 20. TabContents -> WebContents in chrome/, part 3. BUG=105875 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -41 lines) Patch
M chrome/browser/printing/background_printing_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_job.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_message_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/restore_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/chrome_web_contents_view_delegate_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/language_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
8 years, 8 months ago (2012-04-17 14:55:21 UTC) #1
jam
lgtm
8 years, 8 months ago (2012-04-17 15:05:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9969208/1
8 years, 8 months ago (2012-04-17 15:16:53 UTC) #3
commit-bot: I haz the power
Presubmit check for 9969208-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-17 15:17:05 UTC) #4
marja
> Missing LGTM from an OWNER for files in these directories: > chrome/browser/sessions chrome/browser/sessions lgtm
8 years, 8 months ago (2012-04-17 15:23:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9969208/1
8 years, 8 months ago (2012-04-17 19:52:06 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 19:52:21 UTC) #7 
Presubmit check for 9969208-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/printing
    chrome/browser/search_engines
    chrome/browser/sync
    chrome/browser/tabs

Presubmit checks took 2.0s to calculate.

Powered by Google App Engine
This is Rietveld 408576698