Issue 9969191: Make SearchBox extension call through WebFrame to execute page script

Issue 9969191: Make SearchBox extension call through WebFrame to execute page script (Closed)

Created:
8 years, 8 months ago by rafaelw

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make SearchBox extension call through WebFrame to execute page script This cleans up another instance of renderer code directly invoking page/author script. When all instances are fixed, we can land https://bugs.webkit.org/show_bug.cgi?id=84094 BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132526

Patch Set 1 #

Patch Set 2 : removed test changes #

Patch Set 3 : cleanup #

Total comments: 2

Patch Set 4 : indent #

Patch Set 5 : patch for landing #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -41 lines)			Patch
	M	chrome/renderer/searchbox_extension.cc	View	1 2 3	2 chunks	+45 lines, -41 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://chromiumcodereview.appspot.com/9969191/diff/3001/chrome/renderer/searchbox_extension.cc File chrome/renderer/searchbox_extension.cc (right): https://chromiumcodereview.appspot.com/9969191/diff/3001/chrome/renderer/searchbox_extension.cc#newcode390 chrome/renderer/searchbox_extension.cc:390: frame->executeScript(WebScriptSource(no_event_handler_script)); nit: 2 space indent.

8 years, 8 months ago (2012-04-16 23:37:15 UTC) #2

rafaelw

https://chromiumcodereview.appspot.com/9969191/diff/3001/chrome/renderer/searchbox_extension.cc File chrome/renderer/searchbox_extension.cc (right): https://chromiumcodereview.appspot.com/9969191/diff/3001/chrome/renderer/searchbox_extension.cc#newcode390 chrome/renderer/searchbox_extension.cc:390: frame->executeScript(WebScriptSource(no_event_handler_script)); On 2012/04/16 23:37:16, sky wrote: > nit: 2 ...

8 years, 8 months ago (2012-04-16 23:41:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/9969191/3003

8 years, 8 months ago (2012-04-16 23:41:41 UTC) #4

commit-bot: I haz the power

Try job failure for 9969191-3003 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=18396 Step "update" is always ...

8 years, 8 months ago (2012-04-16 23:43:04 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/9969191/6004

8 years, 8 months ago (2012-04-17 00:02:57 UTC) #6

Change committed as 132526

Expand Messages | Collapse Messages