Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: chrome/browser/ui/browser.h

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extraneous logging Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index d05204ea6910c99ebd53c4653389ed3d1a37e8cd..22dd6524fb4dae2c273ccd2ff9f6fd5aca54bcfa 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -148,6 +148,14 @@ class Browser : public TabHandlerDelegate,
};
struct CreateParams {
+ static CreateParams CreateForApp(Type type,
+ const std::string& app_name,
+ const gfx::Rect& window_bounds,
+ Profile* profile);
+
+ static CreateParams CreateForDevTools(Profile* profile);
+
+ CreateParams();
CreateParams(Type type, Profile* profile);
// The browser type.
@@ -190,22 +198,6 @@ class Browser : public TabHandlerDelegate,
// Like Create, but creates a browser of the specified parameters.
static Browser* CreateWithParams(const CreateParams& params);
- // Like Create, but creates a browser of the specified type.
- static Browser* CreateForType(Type type, Profile* profile);
-
- // Like Create, but creates a toolbar-less "app" window for the specified
- // app. |app_name| is required and is used to identify the window to the
- // shell. If |window_bounds| is set, it is used to determine the bounds of
- // the window to open.
- static Browser* CreateForApp(Type type,
- const std::string& app_name,
- const gfx::Rect& window_bounds,
- Profile* profile);
-
- // Like Create, but creates a tabstrip-less and toolbar-less
- // DevTools "app" window.
- static Browser* CreateForDevTools(Profile* profile);
-
// Set overrides for the initial window bounds and maximized state.
void set_override_bounds(const gfx::Rect& bounds) {
override_bounds_ = bounds;

Powered by Google App Engine
This is Rietveld 408576698