Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 9968037: Merge 112549 - Web Inspector: subtree disapears from <iframe> after loading (Closed)

Created:
8 years, 8 months ago by pfeldman
Modified:
8 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 112549 - Web Inspector: subtree disapears from <iframe> after loading https://bugs.webkit.org/show_bug.cgi?id=76552 Reviewed by Yury Semikhatsky. Source/WebCore: The problem was that content document subtree was not unbound upon iframe re-push. Upon owner element refresh content document was not sent to the frontend since backend assumed that front-end has already had the up-to-date version. Test: inspector/elements/iframe-load-event.html * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::loadEventFired): LayoutTests: * inspector/elements/iframe-load-event-expected.txt: Added. * inspector/elements/iframe-load-event.html: Added. * inspector/elements/resources/iframe-load-event-iframe-1.html: Added. * inspector/elements/resources/iframe-load-event-iframe-2.html: Added. * inspector/elements/resources/iframe-load-event-iframe.js: Added. (loadSecondIFrame): (test.step1.nodeInserted): (test.step1): (test.step2): (test): TBR=pfeldman@chromium.org BUG=121116 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=112847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
A + LayoutTests/inspector/elements/iframe-load-event.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/elements/iframe-load-event-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/elements/resources/iframe-load-event-iframe.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/elements/resources/iframe-load-event-iframe-1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/elements/resources/iframe-load-event-iframe-2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMAgent.cpp View 1 chunk +8 lines, -14 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
8 years, 8 months ago (2012-04-02 10:02:02 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698