Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: Source/WebCore/inspector/InspectorDOMAgent.cpp

Issue 9968037: Merge 112549 - Web Inspector: subtree disapears from <iframe> after loading (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/elements/resources/iframe-load-event-iframe-2.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/inspector/InspectorDOMAgent.cpp
===================================================================
--- Source/WebCore/inspector/InspectorDOMAgent.cpp (revision 112844)
+++ Source/WebCore/inspector/InspectorDOMAgent.cpp (working copy)
@@ -1365,20 +1365,14 @@
if (!frameOwnerId)
return;
- if (!m_childrenRequested.contains(frameOwnerId)) {
- // No children are mapped yet -> only notify on changes of hasChildren.
- m_frontend->childNodeCountUpdated(frameOwnerId, innerChildNodeCount(frameOwner));
- } else {
- // Re-add frame owner element together with its new children.
- int parentId = m_documentNodeToIdMap.get(innerParentNode(frameOwner));
- m_frontend->childNodeRemoved(parentId, frameOwnerId);
- RefPtr<InspectorObject> value = buildObjectForNode(frameOwner, 0, &m_documentNodeToIdMap);
- Node* previousSibling = innerPreviousSibling(frameOwner);
- int prevId = previousSibling ? m_documentNodeToIdMap.get(previousSibling) : 0;
- m_frontend->childNodeInserted(parentId, prevId, value.release());
- // Invalidate children requested flag for the element.
- m_childrenRequested.remove(m_childrenRequested.find(frameOwnerId));
- }
+ // Re-add frame owner element together with its new children.
+ int parentId = m_documentNodeToIdMap.get(innerParentNode(frameOwner));
+ m_frontend->childNodeRemoved(parentId, frameOwnerId);
+ unbind(frameOwner, &m_documentNodeToIdMap);
+ RefPtr<InspectorObject> value = buildObjectForNode(frameOwner, 0, &m_documentNodeToIdMap);
+ Node* previousSibling = innerPreviousSibling(frameOwner);
+ int prevId = previousSibling ? m_documentNodeToIdMap.get(previousSibling) : 0;
+ m_frontend->childNodeInserted(parentId, prevId, value.release());
}
void InspectorDOMAgent::didInsertDOMNode(Node* node)
« no previous file with comments | « LayoutTests/inspector/elements/resources/iframe-load-event-iframe-2.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698