Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Unified Diff: chrome/browser/protector/settings_change_global_error.cc

Issue 9968007: [protector] Support for collapsing multiple changes into a single one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tried to compile after merge. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/protector/settings_change_global_error.cc
diff --git a/chrome/browser/protector/settings_change_global_error.cc b/chrome/browser/protector/settings_change_global_error.cc
index a51103b9102069c8d894fec1106dd256af96f642..d2217bec53d83606a2d29b15ca51d51d056b99f2 100644
--- a/chrome/browser/protector/settings_change_global_error.cc
+++ b/chrome/browser/protector/settings_change_global_error.cc
@@ -165,6 +165,9 @@ string16 SettingsChangeGlobalError::GetBubbleViewCancelButtonLabel() {
}
void SettingsChangeGlobalError::OnBubbleViewDidClose(Browser* browser) {
+ // The bubble may be closed as the result of RemoveFromProfile call.
whywhat 2012/04/06 16:28:32 Could you add more details on when RemoveFromProfi
Ivan Korotkov 2012/04/09 14:46:47 Done.
+ if (!profile_)
+ return;
if (!closed_by_button_) {
BrowserThread::PostDelayedTask(
BrowserThread::UI, FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698