[protector] Support for collapsing multiple changes into a single one.

chrome/browser/protector/settings_change_global_error.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/protector/settings_change_global_error.h"
 
 #include <bitset>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 147 matching lines @@
 
 string16 SettingsChangeGlobalError::GetBubbleViewAcceptButtonLabel() {
   return change_->GetDiscardButtonText();
 }
 
 string16 SettingsChangeGlobalError::GetBubbleViewCancelButtonLabel() {
   return change_->GetApplyButtonText();
 }
 
 void SettingsChangeGlobalError::OnBubbleViewDidClose(Browser* browser) {
+  // The bubble may be closed as the result of RemoveFromProfile call.

[whywhat, 2012/04/06 16:28:32]

Could you add more details on when RemoveFromProfile is called so that this
situation occurs?

[Ivan Korotkov, 2012/04/09 14:46:47]

Done.

+  if (!profile_)
+    return;
   if (!closed_by_button_) {
     BrowserThread::PostDelayedTask(
         BrowserThread::UI, FROM_HERE,
         base::Bind(&SettingsChangeGlobalError::OnInactiveTimeout,
                    weak_factory_.GetWeakPtr()),
         base::TimeDelta::FromMilliseconds(kMenuItemDisplayPeriodMs));
 #if !defined(TOOLKIT_GTK)
     // TODO(ivankr): the logic for redisplaying bubble is disabled on Gtk, see
     // http://crbug.com/115719.
     if (browser->window() &&
@@ skipping 44 matching lines @@
   weak_factory_.InvalidateWeakPtrs();
   ShowBubbleView(browser);
 }
 
 void SettingsChangeGlobalError::OnInactiveTimeout() {
   delegate_->OnDecisionTimeout(this);
   RemoveFromProfile();
 }
 
 }  // namespace protector