Issue 9966007: views: Extract SystemMenuModel from native_menu_win.*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9966007: views: Extract SystemMenuModel from native_menu_win.*. (Closed)

Created:
8 years, 8 months ago by tfarina

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Extract SystemMenuModel from native_menu_win.*. This patch moves a model used by BrowserFrameWin near where it's really used, and into a place that looks more appropriated, which is to frame/ directory, near to system_menu_model_delegate.*. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130950

Patch Set 1 : #

Patch Set 2 : fix win #

Patch Set 3 : include string16 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -38 lines)			Patch
M	chrome/browser/ui/views/frame/browser_frame_win.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	chrome/browser/ui/views/frame/system_menu_model.h	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/frame/system_menu_model.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/views/controls/menu/native_menu_win.h	View	1 2	2 chunks	+5 lines, -19 lines	0 comments	Download
M	ui/views/controls/menu/native_menu_win.cc	View	1	2 chunks	+1 line, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages