Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 9965143: Revert 130431 - Move the URL string from TemplateURLRef onto the owning TemplateURL. This will mak… (Closed)

Created:
8 years, 8 months ago by Dan Beam
Modified:
8 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, dhollowa+watch_chromium.org, kkania, robertshield, tfarina, James Su, tim (not reviewing)
Visibility:
Public.

Description

Revert 130431 - Move the URL string from TemplateURLRef onto the owning TemplateURL. This will make it easier to move the data members of TemplateURL into a new class later. This changes the accessors for TemplateURL's TemplateURLRefs. There are now separate accessors for the URLs as strings and as TemplateURLRefs, and the latter have changed to returning a const ref, meaning they no longer return NULL when the corresponding URL string is empty. This makes a number of callers clearer. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9968016 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+754 lines, -679 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/profile_import_process_messages.h View 3 chunks +43 lines, -26 lines 0 comments Download
M chrome/browser/importer/profile_writer.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/protector/default_search_provider_change.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/protector/default_search_provider_change_browsertest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/protector/histograms.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/search_host_to_urls_map.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url.h View 9 chunks +41 lines, -34 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 14 chunks +59 lines, -63 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_parser.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/search_engines/template_url_parser_unittest.cc View 7 chunks +26 lines, -18 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 17 chunks +52 lines, -39 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 16 chunks +170 lines, -206 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 14 chunks +36 lines, -29 lines 0 comments Download
M chrome/browser/search_engines/template_url_unittest.cc View 14 chunks +136 lines, -126 lines 0 comments Download
M chrome/browser/sync/test/integration/search_engines_helper.cc View 2 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/edit_search_engine_dialog.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/edit_search_engine_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
MM chrome/browser/ui/webui/options2/search_engine_manager_handler2.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/keyword_table.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/webdata/keyword_table_unittest.cc View 5 chunks +26 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Dan Beam
8 years, 8 months ago (2012-04-04 06:49:51 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698