Revert 130431 - Move the URL string from TemplateURLRef onto the owning TemplateURL. This will mak…

chrome/browser/protector/default_search_provider_change.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 36 matching lines @@
   }
 
   // Returns true if both |other| and |url| are NULL or have same field values.
   bool operator()(const TemplateURL* url) {
     if (url == other_ )
       return true;
     if (!url || !other_)
       return false;
     return url->short_name() == other_->short_name() &&
         AreKeywordsSame(url, other_) &&
-        url->url() == other_->url() &&
-        url->suggestions_url() == other_->suggestions_url() &&
-        url->instant_url() == other_->instant_url() &&
+        TemplateURLRef::SameUrlRefs(url->url(), other_->url()) &&
+        TemplateURLRef::SameUrlRefs(url->suggestions_url(),
+                                    other_->suggestions_url()) &&
+        TemplateURLRef::SameUrlRefs(url->instant_url(),
+                                    other_->instant_url()) &&
+        url->favicon_url() == other_->favicon_url() &&
         url->safe_for_autoreplace() == other_->safe_for_autoreplace() &&
-        url->favicon_url() == other_->favicon_url() &&
         url->show_in_default_list() == other_->show_in_default_list() &&
         url->input_encodings() == other_->input_encodings() &&
         url->prepopulate_id() == other_->prepopulate_id();
   }
 
  private:
   // Returns true if both |url1| and |url2| have autogenerated keywords
   // or if their keywords are identical.
   bool AreKeywordsSame(const TemplateURL* url1, const TemplateURL* url2) {
     return (url1->autogenerate_keyword() && url2->autogenerate_keyword()) ||
@@ skipping 319 matching lines @@
   DCHECK(url_service);
   return url_service;
 }
 
 BaseSettingChange* CreateDefaultSearchProviderChange(const TemplateURL* actual,
                                                      TemplateURL* backup) {
   return new DefaultSearchProviderChange(actual, backup);
 }
 
 }  // namespace protector