Issue 9965037: Adding build-time option to enable the tracing of skia events in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9965037: Adding build-time option to enable the tracing of skia events in (Closed)

Created:
8 years, 8 months ago by Justin Novosad

Modified:
8 years, 8 months ago

Reviewers:
epoger, senorblanco

CC:
chromium-reviews, reed1, epoger

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Adding build-time option to enable the tracing of skia events in chrome://tracing BUG=121208 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130469

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
M	skia/config/SkUserConfig.h	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
A	skia/ext/skia_trace_shim.h	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	skia/skia.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

senorblanco

https://chromiumcodereview.appspot.com/9965037/diff/1/skia/skia.gyp File skia/skia.gyp (right): https://chromiumcodereview.appspot.com/9965037/diff/1/skia/skia.gyp#newcode767 skia/skia.gyp:767: 'SK_USER_TRACE_INCLUDE_FILE="skia/ext/skia_trace_shim.h"', I'd prefer to do this all in one ...

8 years, 8 months ago (2012-04-02 20:49:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/9965037/6

8 years, 8 months ago (2012-04-03 18:43:21 UTC) #6

Change committed as 130469

Expand Messages | Collapse Messages

Issue 9965037: Adding build-time option to enable the tracing of skia events in (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages