Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 9965022: Allow substitution of messages as variables in other messages. (Closed)

Created:
8 years, 8 months ago by Jói
Modified:
8 years, 8 months ago
Reviewers:
tony
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Allow substitution of messages as variables in other messages. This is part of a manual merge of changes released to the internal branch 2008/06/11. Original author is Marc-Antoine Parent. In addition to the merge, bring in all language directive mappings and codepage mappings from the latest internal version of grit to avoid warnings related to unknown output languages. While updating the mapping, fix the name of the fake-bidi language. Finally, to help debug differences in data_pack files, add a simple ASCII converter to data_pack.py BUG=http://code.google.com/p/grit-i18n/issues/detail?id=4 Committed: https://code.google.com/p/grit-i18n/source/detail?r=26

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Add more charset and language directive pairs. Add datapack dump tool. Fix name of fake-bidi langua… #

Patch Set 4 : Fix unit tests for policy writers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+802 lines, -352 lines) Patch
M grit/clique_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M grit/format/c_format.py View 3 chunks +23 lines, -22 lines 0 comments Download
M grit/format/data_pack.py View 1 2 2 chunks +15 lines, -10 lines 0 comments Download
M grit/format/interface.py View 1 chunk +27 lines, -12 lines 0 comments Download
M grit/format/js_map_format.py View 2 chunks +5 lines, -14 lines 0 comments Download
M grit/format/policy_templates/template_formatter.py View 2 chunks +1 line, -4 lines 0 comments Download
M grit/format/policy_templates/writers/writer_unittest_common.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M grit/format/rc.py View 1 2 8 chunks +223 lines, -158 lines 0 comments Download
M grit/format/rc_header.py View 3 chunks +16 lines, -25 lines 0 comments Download
M grit/format/rc_unittest.py View 4 chunks +101 lines, -1 line 0 comments Download
M grit/format/resource_map.py View 4 chunks +21 lines, -28 lines 0 comments Download
M grit/gather/admin_template_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M grit/gather/interface.py View 2 chunks +9 lines, -1 line 0 comments Download
M grit/gather/skeleton_gatherer.py View 1 chunk +21 lines, -0 lines 0 comments Download
M grit/gather/tr_html.py View 2 chunks +20 lines, -2 lines 0 comments Download
M grit/node/base.py View 4 chunks +22 lines, -11 lines 0 comments Download
M grit/node/io_unittest.py View 3 chunks +3 lines, -0 lines 0 comments Download
M grit/node/message.py View 5 chunks +30 lines, -6 lines 0 comments Download
M grit/node/misc.py View 1 2 3 8 chunks +70 lines, -1 line 0 comments Download
M grit/node/misc_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M grit/node/structure.py View 1 5 chunks +31 lines, -20 lines 0 comments Download
M grit/testdata/klonk.rc View 0 chunks +-1 lines, --1 lines 0 comments Download
M grit/testdata/source.rc View 3 chunks +3 lines, -3 lines 0 comments Download
M grit/testdata/transl.rc View 3 chunks +3 lines, -3 lines 0 comments Download
M grit/tool/build.py View 7 chunks +9 lines, -28 lines 0 comments Download
M grit/tool/resize.py View 3 chunks +2 lines, -3 lines 0 comments Download
M grit/tool/transl2tc.py View 1 chunk +4 lines, -0 lines 0 comments Download
M grit/tool/transl2tc_unittest.py View 2 chunks +2 lines, -1 line 0 comments Download
M grit/util.py View 1 chunk +138 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jói
This is a bit of a preview as in its current state the change modifies ...
8 years, 8 months ago (2012-03-30 17:12:36 UTC) #1
Jói
Tony, this is ready for review now. There is still a minor difference in the ...
8 years, 8 months ago (2012-04-02 14:28:20 UTC) #2
Jói
Sorry, that was missing some context. The diff is a diff of the output of ...
8 years, 8 months ago (2012-04-02 14:29:56 UTC) #3
tony
8 years, 8 months ago (2012-04-02 17:40:29 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698