Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9963116: Add perf results for GPU bots on chromium.gpu and chromium.webkit waterfalls. (Closed)

Created:
8 years, 8 months ago by Zhenyao Mo
Modified:
8 years, 8 months ago
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Add perf results for GPU bots on chromium.gpu and chromium.webkit waterfalls. BUG=117719 TEST=chromium.gpu and chromium.webkit waterfalls, gpu bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130446

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M masters/master.chromium.gpu/master.cfg View 3 chunks +6 lines, -0 lines 0 comments Download
M masters/master.chromium.webkit/master_linux_latest_cfg.py View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M masters/master.chromium.webkit/master_mac_latest_cfg.py View 1 chunk +2 lines, -0 lines 0 comments Download
M masters/master.chromium.webkit/master_win_latest_cfg.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Zhenyao Mo
Please review.
8 years, 8 months ago (2012-04-03 18:04:46 UTC) #1
cmp
https://chromiumcodereview.appspot.com/9963116/diff/1/scripts/master/factory/commands.py File scripts/master/factory/commands.py (right): https://chromiumcodereview.appspot.com/9963116/diff/1/scripts/master/factory/commands.py#newcode134 scripts/master/factory/commands.py:134: 'gpu-webkit-linux-nvidia': 'gpu-webkit-linux-nvidia', lines 129-134 should not be necessary and ...
8 years, 8 months ago (2012-04-03 19:12:32 UTC) #2
Zhenyao Mo
https://chromiumcodereview.appspot.com/9963116/diff/1/scripts/master/factory/commands.py File scripts/master/factory/commands.py (right): https://chromiumcodereview.appspot.com/9963116/diff/1/scripts/master/factory/commands.py#newcode134 scripts/master/factory/commands.py:134: 'gpu-webkit-linux-nvidia': 'gpu-webkit-linux-nvidia', On 2012/04/03 19:12:32, cmp wrote: > lines ...
8 years, 8 months ago (2012-04-03 19:51:10 UTC) #3
cmp
lgtm with nit https://chromiumcodereview.appspot.com/9963116/diff/5001/masters/master.chromium.webkit/master_linux_latest_cfg.py File masters/master.chromium.webkit/master_linux_latest_cfg.py (right): https://chromiumcodereview.appspot.com/9963116/diff/5001/masters/master.chromium.webkit/master_linux_latest_cfg.py#newcode71 masters/master.chromium.webkit/master_linux_latest_cfg.py:71: 'show_perf_results': True nit: add a comma ...
8 years, 8 months ago (2012-04-03 20:16:07 UTC) #4
Zhenyao Mo
https://chromiumcodereview.appspot.com/9963116/diff/5001/masters/master.chromium.webkit/master_linux_latest_cfg.py File masters/master.chromium.webkit/master_linux_latest_cfg.py (right): https://chromiumcodereview.appspot.com/9963116/diff/5001/masters/master.chromium.webkit/master_linux_latest_cfg.py#newcode71 masters/master.chromium.webkit/master_linux_latest_cfg.py:71: 'show_perf_results': True On 2012/04/03 20:16:07, cmp wrote: > nit: ...
8 years, 8 months ago (2012-04-03 20:23:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/9963116/7001
8 years, 8 months ago (2012-04-03 20:24:19 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-03 20:27:09 UTC) #7 
Change committed as 130446

Powered by Google App Engine
This is Rietveld 408576698