Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 9963004: Use the new syntax for native methods that are just renames of other native methods. (Closed)

Created:
8 years, 8 months ago by Jacob
Modified:
8 years, 8 months ago
Reviewers:
nweiz, sra1
CC:
reviews_dartlang.org, nweiz
Visibility:
Public.

Description

Use the new syntax for native methods that are just renames of other native methods. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6053

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : Ready to review... Sra's change actually fixed a failing test instead of causing a new test to fail! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -72 lines) Patch
M client/tests/client/client.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M lib/dom/scripts/systemhtml.py View 1 1 chunk +1 line, -4 lines 0 comments Download
M lib/html/frog/html_frog.dart View 25 chunks +65 lines, -65 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-query-html.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/dromaeo/tests/dom-query-htmlidiomatic.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jacob
This code improves performance on chrome, reduces, download size, but causes one test to fail ...
8 years, 8 months ago (2012-03-30 03:47:36 UTC) #1
Jacob
Ready to review
8 years, 8 months ago (2012-03-30 04:21:48 UTC) #2
sra1
lgtm
8 years, 8 months ago (2012-03-30 06:21:26 UTC) #3
nweiz
8 years, 8 months ago (2012-03-30 18:30:08 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698