lib/dom/scripts/systemhtml.py - Issue 9963004: Use the new syntax for native methods that are just renames of other native methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/systemhtml.py

Issue 9963004: Use the new syntax for native methods that are just renames of other native methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Ready to review... Sra's change actually fixed a failing test instead of causing a new test to fail! Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/dom/scripts/systemhtml.py

diff --git a/lib/dom/scripts/systemhtml.py b/lib/dom/scripts/systemhtml.py

index 18c7176451aa1c179ecc3d49277737d7a07032e2..b5fd89b2195832b9cb29d2733df175d8045e412b 100644

--- a/lib/dom/scripts/systemhtml.py

+++ b/lib/dom/scripts/systemhtml.py

@@ -981,15 +981,12 @@ class HtmlFrogClassGenerator(FrogInterfaceGenerator):

TYPE=return_type,

HTML_NAME=html_name,

NAME=info.name,

- RETURN='' if return_type == 'void' else 'return ',

- PARAMNAMES=info.ParametersAsArgumentList(),

PARAMS=info.ParametersImplementationDeclaration(

lambda type_name: self._NarrowInputType(type_name)))

operation_emitter.Emit(

'\n'

- ' $TYPE $(HTML_NAME)($PARAMS)'

- ' native "$(RETURN)this.$NAME($PARAMNAMES);";\n')

+ ' $TYPE $(HTML_NAME)($PARAMS) native "$NAME";\n')

else:

self._members_emitter.Emit(

'\n'

« no previous file with comments | « client/tests/client/client.status ('k') | lib/html/frog/html_frog.dart » ('j') | no next file with comments »