chrome/browser/extensions/extension_disabled_ui_browsertest.cc - Issue 996213005: Don't crash when trying to create an ExtensionSyncData from invalid SyncData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_disabled_ui_browsertest.cc

Issue 996213005: Don't crash when trying to create an ExtensionSyncData from invalid SyncData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: kalmanize Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/app_sync_data_unittest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_disabled_ui_browsertest.cc

diff --git a/chrome/browser/extensions/extension_disabled_ui_browsertest.cc b/chrome/browser/extensions/extension_disabled_ui_browsertest.cc

index c3cd1097d536a4d17cab65fa3a7a36831f0e4f8f..ca09c231e0ea8467db4962d72c78dc5e5175341a 100644

--- a/chrome/browser/extensions/extension_disabled_ui_browsertest.cc

+++ b/chrome/browser/extensions/extension_disabled_ui_browsertest.cc

@@ -238,7 +238,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionDisabledGlobalErrorTest, RemoteInstall) {

syncer::AttachmentServiceProxy());

// Sync is installing a new extension, so it pends.

EXPECT_FALSE(sync_service->ProcessExtensionSyncData(

- extensions::ExtensionSyncData(sync_data)));

+ *extensions::ExtensionSyncData::CreateFromSyncData(sync_data)));

WaitForExtensionInstall();

content::RunAllBlockingPoolTasksUntilIdle();

« no previous file with comments | « chrome/browser/extensions/app_sync_data_unittest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »