Don't crash when trying to create an ExtensionSyncData from invalid SyncData.

chrome/browser/extensions/app_sync_data_unittest.cc

Index: chrome/browser/extensions/app_sync_data_unittest.cc
diff --git a/chrome/browser/extensions/app_sync_data_unittest.cc b/chrome/browser/extensions/app_sync_data_unittest.cc
index 97fafbde574b9e0dc98ea9fc19fcdc92e78e7f4c..5b906210034cd4f16955710b7c090aa7b297a012 100644
--- a/chrome/browser/extensions/app_sync_data_unittest.cc
+++ b/chrome/browser/extensions/app_sync_data_unittest.cc
@@ -48,11 +48,13 @@ TEST_F(AppSyncDataTest, SyncDataToExtensionSyncDataForApp) {
   syncer::SyncData sync_data =
       syncer::SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
 
-  AppSyncData app_sync_data(sync_data);
+  scoped_ptr<AppSyncData> app_sync_data =
+      AppSyncData::CreateFromSyncData(sync_data);
+  ASSERT_TRUE(app_sync_data.get());
   EXPECT_EQ(app_specifics->app_launch_ordinal(),
-            app_sync_data.app_launch_ordinal().ToInternalValue());
+            app_sync_data->app_launch_ordinal().ToInternalValue());
   EXPECT_EQ(app_specifics->page_ordinal(),
-            app_sync_data.page_ordinal().ToInternalValue());
+            app_sync_data->page_ordinal().ToInternalValue());
 }
 
 
@@ -69,9 +71,11 @@ TEST_F(AppSyncDataTest, ExtensionSyncDataToSyncDataForApp) {
 
   syncer::SyncData sync_data =
       syncer::SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
-  AppSyncData app_sync_data(sync_data);
+  scoped_ptr<AppSyncData> app_sync_data =
+      AppSyncData::CreateFromSyncData(sync_data);
+  ASSERT_TRUE(app_sync_data.get());
 
-  syncer::SyncData output_sync_data = app_sync_data.GetSyncData();
+  syncer::SyncData output_sync_data = app_sync_data->GetSyncData();
   EXPECT_TRUE(sync_data.GetSpecifics().has_app());
   const sync_pb::AppSpecifics& output_specifics =
       output_sync_data.GetSpecifics().app();
@@ -93,8 +97,10 @@ TEST_F(AppSyncDataTest, ExtensionSyncDataInvalidOrdinal) {
       syncer::SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
 
   // There should be no issue loading the sync data.
-  AppSyncData app_sync_data(sync_data);
-  app_sync_data.GetSyncData();
+  scoped_ptr<AppSyncData> app_sync_data =
+      AppSyncData::CreateFromSyncData(sync_data);
+  ASSERT_TRUE(app_sync_data.get());
+  app_sync_data->GetSyncData();
 }
 
 }  // namespace extensions