chrome/browser/apps/ephemeral_app_browsertest.cc - Issue 996213005: Don't crash when trying to create an ExtensionSyncData from invalid SyncData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_browsertest.cc

Issue 996213005: Don't crash when trying to create an ExtensionSyncData from invalid SyncData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/ephemeral_app_browsertest.cc

diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc

index fd1d298e93e56c4753f68fe4497c4f9fbe0337ae..c0fc7a2bf98acb37f598e86ba924fdaa9948103d 100644

--- a/chrome/browser/apps/ephemeral_app_browsertest.cc

+++ b/chrome/browser/apps/ephemeral_app_browsertest.cc

@@ -533,7 +533,7 @@ class EphemeralAppBrowserTest : public EphemeralAppTestBase {

for (syncer::SyncChangeList::iterator it =

mock_sync_processor_.changes().begin();

it != mock_sync_processor_.changes().end(); ++it) {

- scoped_ptr<AppSyncData> data(new AppSyncData(*it));

+ scoped_ptr<AppSyncData> data(AppSyncData::CreateFromSyncChange(*it));

if (data->id() == id)

not at google - send to devlin 2015/03/11 23:21:34 It could be null, though?

Yoyo Zhou 2015/03/12 00:25:48 Done.

sync_data.reset(data.release());

}

« no previous file with comments | « no previous file | chrome/browser/extensions/app_sync_bundle.cc » ('j') | chrome/browser/extensions/app_sync_bundle.cc » ('J')