Don't crash when trying to create an ExtensionSyncData from invalid SyncData.

chrome/browser/apps/ephemeral_app_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/apps/ephemeral_app_browsertest.h"
 
 #include <vector>
 
 #include "apps/app_restore_service.h"
 #include "apps/saved_files_service.h"
@@ skipping 515 matching lines @@
                 &mock_sync_processor_)),
         scoped_ptr<syncer::SyncErrorFactory>(
             new syncer::SyncErrorFactoryMock()));
   }
 
   scoped_ptr<AppSyncData> GetLastSyncChangeForApp(const std::string& id) {
     scoped_ptr<AppSyncData> sync_data;
     for (syncer::SyncChangeList::iterator it =
              mock_sync_processor_.changes().begin();
          it != mock_sync_processor_.changes().end(); ++it) {
-      scoped_ptr<AppSyncData> data(new AppSyncData(*it));
+      scoped_ptr<AppSyncData> data(AppSyncData::CreateFromSyncChange(*it));
       if (data->id() == id)

[not at google - send to devlin, 2015/03/11 23:21:34]

It could be null, though?

[Yoyo Zhou, 2015/03/12 00:25:48]

Done.

         sync_data.reset(data.release());
     }
 
     return sync_data.Pass();
   }
 
   void VerifySyncChange(const AppSyncData* sync_change, bool expect_enabled) {
     if (!kEnableSync)
       return;
 
@@ skipping 484 matching lines @@
       base::Bind(&PowerSaveBlockerStub::Create, &power_settings));
 
   const Extension* app = InstallAndLaunchEphemeralApp(kPowerTestApp);
   ASSERT_TRUE(app);
   EXPECT_EQ(1, power_settings.keep_awake_count());
 
   CloseAppWaitForUnload(app->id());
 
   EXPECT_EQ(0, power_settings.keep_awake_count());
 }