chrome/browser/extensions/extension_disabled_ui.cc - Issue 9960087: Revert 13676 - Revert 131665 - Add a preference for why an extension is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_disabled_ui.cc

Issue 9960087: Revert 13676 - Revert 131665 - Add a preference for why an extension is disabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | chrome/browser/extensions/extension_disabled_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_disabled_ui.cc

diff --git a/chrome/browser/extensions/extension_disabled_ui.cc b/chrome/browser/extensions/extension_disabled_ui.cc

index ed8c203dd11c8883f5bdef9c5edd082c580be2d7..1d7d59ffa0db8eb97fa991961fc3906ef6a7e9a9 100644

--- a/chrome/browser/extensions/extension_disabled_ui.cc

+++ b/chrome/browser/extensions/extension_disabled_ui.cc

@@ -188,6 +188,7 @@ ExtensionDisabledGlobalError::ExtensionDisabledGlobalError(

}

ExtensionDisabledGlobalError::~ExtensionDisabledGlobalError() {

+ ReleaseMenuCommandID(menu_command_id_);

HISTOGRAM_ENUMERATION("Extensions.DisabledUIUserResponse",

user_response_, EXTENSION_DISABLED_UI_BUCKET_BOUNDARY);

}

@@ -283,7 +284,6 @@ void ExtensionDisabledGlobalError::Observe(

if (extension == extension_) {

GlobalErrorServiceFactory::GetForProfile(service_->profile())->

RemoveGlobalError(this);

- ReleaseMenuCommandID(menu_command_id_);

if (type == chrome::NOTIFICATION_EXTENSION_LOADED)

user_response_ = REENABLE;