Issue 9960087: Revert 13676 - Revert 131665 - Add a preference for why an extension is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9960087: Revert 13676 - Revert 131665 - Add a preference for why an extension is disabled. (Closed)

Created:
8 years, 8 months ago by Yoyo Zhou

Modified:
8 years, 8 months ago

Reviewers:

CC:
chromium-reviews, ncarter (slow), jennb, akalin, Raghu Simha, kkania, mihaip+watch_chromium.org, dcheng, Dmitry Titov, Aaron Boodman, robertshield, jianli, Dmitry Lomov (no reviews), Andrei, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert 13676 - Revert 131665 - Add a preference for why an extension is disabled. Doesn't delete the CRXes yet since ExtensionManagementApiEscalationTest needs them. BUG=121436 TEST=browser_tests TBR=aa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131678

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+239 lines, -48 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_context_menu_model.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_disabled_ui.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_disabled_ui_browsertest.cc	View	4 chunks	+93 lines, -13 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_management_apitest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_browsertest.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View	2 chunks	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	9 chunks	+35 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/notifications/notification_options_menu_model.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/sync_extension_helper.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_settings_menu_model.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/permissions_increase/permissions.pem	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/permissions_increase/v1/background.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/permissions_increase/v1/manifest.json	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/permissions_increase/v2/background.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/permissions_increase/v2/manifest.json	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/permissions_increase/v3/background.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/permissions_increase/v3/manifest.json	View	1 chunk	+8 lines, -0 lines	0 comments	Download