Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: src/trusted/validator_arm/inst_classes.cc

Issue 9960043: Finish separation of testing from sel_ldr validation. Also, automate (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_arm/inst_classes.h ('k') | src/trusted/validator_arm/inst_classes_testers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/inst_classes.cc
===================================================================
--- src/trusted/validator_arm/inst_classes.cc (revision 8336)
+++ src/trusted/validator_arm/inst_classes.cc (working copy)
@@ -14,12 +14,6 @@
namespace nacl_arm_dec {
-const char* ClassDecoder::name() const {
- // This should never be called!
- assert(0);
- return "???";
-}
-
uint32_t ShiftTypeBits5To6Interface::ComputeDecodeImmShift(
uint32_t shift_type, uint32_t imm5_value) {
switch (shift_type) {
@@ -86,6 +80,7 @@
// Unsafe if any register contains PC (ARM restriction).
if ((d_.reg(i) + m_.reg(i) + n_.reg(i))[kRegisterPc]) return UNPREDICTABLE;
+
// Note: We would restrict out PC as well for Rd in NaCl, but no need
// since the ARM restriction doesn't allow it anyway.
return MAY_BE_SAFE;
« no previous file with comments | « src/trusted/validator_arm/inst_classes.h ('k') | src/trusted/validator_arm/inst_classes_testers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698