pylib/gyp/win_tool.py - Issue 9959128: ninja windows: simpler link-wrapper code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/win_tool.py

Issue 9959128: ninja windows: simpler link-wrapper code (Closed) Base URL: https://gyp.googlecode.com/svn/trunk

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/win_tool.py

diff --git a/pylib/gyp/win_tool.py b/pylib/gyp/win_tool.py

index 331a655957c8dd71091366cf923f7a0b91441535..1e45955177c3bc1deb4c6168c6b3e550f65bb022 100644

--- a/pylib/gyp/win_tool.py

+++ b/pylib/gyp/win_tool.py

@@ -58,8 +58,7 @@ class WinTool(object):

popen = subprocess.Popen(args,

stdout=subprocess.PIPE,

stderr=subprocess.STDOUT)

- out, _ = popen.communicate()

- for line in out.splitlines():

+ for line in popen.stdout:

if not line.startswith(' Creating library '):

sys.stdout.write(line)

return popen.returncode

« no previous file with comments | « no previous file | no next file » | no next file with comments »