Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 9959061: Use RAII for write libpng structs. (Closed)

Created:
8 years, 8 months ago by Francois
Modified:
4 years ago
Reviewers:
tony, Nico, Elliot Glaysher, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Use RAII for write libpng structs. Previously RAII was only being used for read libpng structs. These changes were split from the patch at http://codereview.chromium.org/9496004 TEST=--gtest_filter=PNGCodec* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130358

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M ui/gfx/codec/png_codec.cc View 1 2 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Francois
Hi guys, please review this, another small refactoring patch that was stripped from http://codereview.chromium.org/9496004 (Support ...
8 years, 8 months ago (2012-04-02 09:16:57 UTC) #1
sky
LGTM. In the future pick just one reviewer. https://chromiumcodereview.appspot.com/9959061/diff/1/ui/gfx/codec/png_codec.cc File ui/gfx/codec/png_codec.cc (right): https://chromiumcodereview.appspot.com/9959061/diff/1/ui/gfx/codec/png_codec.cc#newcode379 ui/gfx/codec/png_codec.cc:379: }; ...
8 years, 8 months ago (2012-04-02 15:35:01 UTC) #2
Francois
On 2012/04/02 15:35:01, sky wrote: > LGTM. In the future pick just one reviewer. > ...
8 years, 8 months ago (2012-04-03 09:01:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/francoisk777@gmail.com/9959061/4001
8 years, 8 months ago (2012-04-03 09:01:41 UTC) #4
commit-bot: I haz the power
Change committed as 130358
8 years, 8 months ago (2012-04-03 12:04:29 UTC) #5
Nico
4 years ago (2016-12-14 20:15:13 UTC) #7
Message was sent while issue was closed.
It's been a few years, but this introduced a subtle (and harmless, but
detectable by tools) bug: https://codereview.chromium.org/2576823002/#msg6

Just in case you're using this RAII class elsewhere :-)

Powered by Google App Engine
This is Rietveld 408576698