Reland 125805 - Reland 124817 - A profile-keyed service for Extensions, ExtensionSystem.

Reland 125805 - Reland 124817 - A profile-keyed service for Extensions, ExtensionSystem.

Move InitExtensions into ExtensionSystem.
Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go.

New since last time: Moved LazyBackgroundTaskQueue into ExtensionSystem.

BUG=104095
TEST=Open and close an incognito window; should not crash.
TBR=aa@chromium.org,akalin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130128

[Yoyo Zhou, 2012-03-30 22:20:08]

erg: please review
aa, akalin: TBR again, no differences on your side from last time

The only differences from the last iteration are around the
LazyBackgroundTaskQueue that was added to Profile and now, as anticipated, will
be moved out of it.

Also, thanks to miket's work, the SocketApiTests are no longer dying in DCHECK.

[Elliot Glaysher, 2012-03-30 22:27:44]

slgtm

Good luck on your next run through the CQ!

[Elliot Glaysher, 2012-03-30 22:29:01]

Looking at the trybot results as they stand, you may need to specify a revision
since miket's patch is so new that it isn't in the lkgr yet...

[Yoyo Zhou, 2012-03-30 22:30:45]

On 2012/03/30 22:29:01, Elliot Glaysher wrote:
> Looking at the trybot results as they stand, you may need to specify a
revision
> since miket's patch is so new that it isn't in the lkgr yet...

Oh, of course. I remembered and then forgot. =/

[commit-bot: I haz the power, 2012-04-02 00:39:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/9959040/1

[commit-bot: I haz the power, 2012-04-02 00:40:01]

Presubmit check for 9959040-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit Warnings **
New code should not use ScopedAllowIO. Post a task to the blocking pool or the
FILE thread instead.
    chrome/browser/extensions/extension_system.cc:117

Presubmit checks took 2.5s to calculate.

[Yoyo Zhou, 2012-04-02 01:02:38]

Looks like we now have a presubmit check against using ScopedAllowIO in "new
code", but this is a refactoring.

aa, mirandac: it looks like you reviewed the ScopedAllowIO when it was added;
it's only used when a command-line flag is present:
http://codereview.chromium.org/8659002/

Do you recommend bypassing this check? The alternative (going to the FILE
thread) presumably adds much more complexity.

[Aaron Boodman, 2012-04-02 01:24:31]

On Sun, Apr 1, 2012 at 6:02 PM,  <yoz@chromium.org> wrote:
> aa, mirandac: it looks like you reviewed the ScopedAllowIO when it was
> added;
> it's only used when a command-line flag is present:
> http://codereview.chromium.org/8659002/
>
> Do you recommend bypassing this check? The alternative (going to the FILE
> thread) presumably adds much more complexity.

Yes.