Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 9959040: Reland 125805 - Reland 124817 - A profile-keyed service for Extensions, ExtensionSystem. (Closed)

Created:
8 years, 8 months ago by Yoyo Zhou
Modified:
8 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, cbentzel+watch_chromium.org, akalin, ncarter (slow), tburkard+watch_chromium.org, Raghu Simha, kkania, mihaip+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, robertshield, tim (not reviewing), brettw-cc_chromium.org, darin-cc_chromium.org, rginda+watch_chromium.org, mmenke, Matt Perry, Miranda Callahan
Visibility:
Public.

Description

Reland 125805 - Reland 124817 - A profile-keyed service for Extensions, ExtensionSystem. Move InitExtensions into ExtensionSystem. Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go. New since last time: Moved LazyBackgroundTaskQueue into ExtensionSystem. BUG=104095 TEST=Open and close an incognito window; should not crash. TBR=aa@chromium.org,akalin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1000 lines, -458 lines) Patch
M chrome/browser/automation/automation_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_handler.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 8 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 13 chunks +40 lines, -38 lines 0 comments Download
A chrome/browser/extensions/extension_system.h View 1 chunk +174 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_system.cc View 1 chunk +291 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_system_factory.h View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_system_factory.cc View 1 chunk +87 lines, -0 lines 0 comments Download
A chrome/browser/extensions/test_extension_system.h View 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/browser/extensions/test_extension_system.cc View 1 chunk +103 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 2 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/intents/web_intents_registry_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 4 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 8 chunks +18 lines, -37 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile.h View 7 chunks +13 lines, -40 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 6 chunks +3 lines, -33 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 9 chunks +11 lines, -167 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 5 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.h View 5 chunks +1 line, -27 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 7 chunks +18 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoyo Zhou
erg: please review aa, akalin: TBR again, no differences on your side from last time ...
8 years, 8 months ago (2012-03-30 22:20:08 UTC) #1
Elliot Glaysher
slgtm Good luck on your next run through the CQ!
8 years, 8 months ago (2012-03-30 22:27:44 UTC) #2
Elliot Glaysher
Looking at the trybot results as they stand, you may need to specify a revision ...
8 years, 8 months ago (2012-03-30 22:29:01 UTC) #3
Yoyo Zhou
On 2012/03/30 22:29:01, Elliot Glaysher wrote: > Looking at the trybot results as they stand, ...
8 years, 8 months ago (2012-03-30 22:30:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/9959040/1
8 years, 8 months ago (2012-04-02 00:39:44 UTC) #5
commit-bot: I haz the power
Presubmit check for 9959040-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-02 00:40:01 UTC) #6
Yoyo Zhou
Looks like we now have a presubmit check against using ScopedAllowIO in "new code", but ...
8 years, 8 months ago (2012-04-02 01:02:38 UTC) #7
Aaron Boodman
8 years, 8 months ago (2012-04-02 01:24:31 UTC) #8
On Sun, Apr 1, 2012 at 6:02 PM,  <yoz@chromium.org> wrote:
> aa, mirandac: it looks like you reviewed the ScopedAllowIO when it was
> added;
> it's only used when a command-line flag is present:
> http://codereview.chromium.org/8659002/
>
> Do you recommend bypassing this check? The alternative (going to the FILE
> thread) presumably adds much more complexity.

Yes.

Powered by Google App Engine
This is Rietveld 408576698