Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 9958109: TaskManager: Replace the string "Page" with "Task" (Closed)

Created:
8 years, 8 months ago by yoshiki
Modified:
8 years, 8 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, arv (Not doing code reviews), yoshiki+watch_chromium.org
Visibility:
Public.

Description

TaskManager: Replace the string "Page" with "Task" This patch just replaces page with task. TBR=estade,sky,thakis BUG=114324 TEST=manual and trybots passes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/task_manager/defines.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.cc View 11 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
mukai: Could you take a look? This patch just replaces "Page" with "Task".
8 years, 8 months ago (2012-04-04 05:48:17 UTC) #1
Jun Mukai
lgtm
8 years, 8 months ago (2012-04-04 06:04:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/9958109/1
8 years, 8 months ago (2012-04-04 06:07:55 UTC) #3
commit-bot: I haz the power
Presubmit check for 9958109-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-04 06:08:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/9958109/1
8 years, 8 months ago (2012-04-04 06:33:25 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-04 09:44:36 UTC) #6
Try job failure for 9958109-1 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698