Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 9958039: Changes the maximize button to only minimize for panels. This resulted (Closed)

Created:
8 years, 8 months ago by sky
Modified:
8 years, 8 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, stevenjb
Visibility:
Public.

Description

Changes the maximize button to only minimize for panels. This resulted in a slew of renaming. Currently the icons are completely wrong for this, but that should be fixed once we get the assets. BUG=121221 TEST=none R=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130064

Patch Set 1 #

Patch Set 2 : Spelling #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -71 lines) Patch
M ash/ash_strings.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/custom_frame_view_ash.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/frame_painter.h View 3 chunks +12 lines, -3 lines 0 comments Download
M ash/wm/frame_painter.cc View 9 chunks +21 lines, -15 lines 1 comment Download
M ash/wm/panel_frame_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/workspace/frame_maximize_button.h View 3 chunks +0 lines, -12 lines 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 3 chunks +4 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc View 5 chunks +24 lines, -11 lines 1 comment Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
This reverts parts of what Steven reverted at http://codereview.chromium.org/9894001 . http://codereview.chromium.org/9958039/diff/1011/ash/wm/frame_painter.cc File ash/wm/frame_painter.cc (right): http://codereview.chromium.org/9958039/diff/1011/ash/wm/frame_painter.cc#newcode266 ...
8 years, 8 months ago (2012-03-31 00:05:12 UTC) #1
sky
I'm adding Ben since James doesn't seem to be around now. I'll go with whoever ...
8 years, 8 months ago (2012-03-31 00:06:00 UTC) #2
James Cook
8 years, 8 months ago (2012-03-31 00:15:07 UTC) #3
LGTM with optional nit.

http://codereview.chromium.org/9958039/diff/1011/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc
(right):

http://codereview.chromium.org/9958039/diff/1011/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc:68:
size_button_minimizes_(false) {
nit: Maybe this could be size_button_behavior_?

Powered by Google App Engine
This is Rietveld 408576698