Changes the maximize button to only minimize for panels. This resulted

chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h"
 
 #include "ash/wm/frame_painter.h"
 #include "ash/wm/workspace/frame_maximize_button.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/views/avatar_menu_button.h"
@@ skipping 43 matching lines @@
 const int kContentShadowHeight = 1;
 
 }  // namespace
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserNonClientFrameViewAura, public:
 
 BrowserNonClientFrameViewAura::BrowserNonClientFrameViewAura(
     BrowserFrame* frame, BrowserView* browser_view)
     : BrowserNonClientFrameView(frame, browser_view),
-      maximize_button_(NULL),
+      size_button_(NULL),
       close_button_(NULL),
       window_icon_(NULL),
-      frame_painter_(new ash::FramePainter) {
+      frame_painter_(new ash::FramePainter),
+      size_button_minimizes_(false) {

[James Cook, 2012/03/31 00:15:09]

nit: Maybe this could be size_button_behavior_?

 }
 
 BrowserNonClientFrameViewAura::~BrowserNonClientFrameViewAura() {
 }
 
 void BrowserNonClientFrameViewAura::Init() {
-  // Caption buttons.
-  maximize_button_ = new ash::FrameMaximizeButton(this, this);
-  maximize_button_->SetAccessibleName(
+  // Panels only minimize.
+  ash::FramePainter::SizeButtonBehavior size_button_behavior;
+  if (browser_view()->browser()->is_type_panel() &&
+      browser_view()->browser()->app_type() == Browser::APP_TYPE_CHILD) {
+    size_button_minimizes_ = true;
+    size_button_ = new views::ImageButton(this);
+    size_button_behavior = ash::FramePainter::SIZE_BUTTON_MINIMIZES;
+  } else {
+    size_button_ = new ash::FrameMaximizeButton(this, this);
+    size_button_behavior = ash::FramePainter::SIZE_BUTTON_MAXIMIZES;
+  }
+  size_button_->SetAccessibleName(
       l10n_util::GetStringUTF16(IDS_ACCNAME_MAXIMIZE));
-  AddChildView(maximize_button_);
+  AddChildView(size_button_);
   close_button_ = new views::ImageButton(this);
   close_button_->SetAccessibleName(
       l10n_util::GetStringUTF16(IDS_ACCNAME_CLOSE));
   AddChildView(close_button_);
 
   // Initializing the TabIconView is expensive, so only do it if we need to.
   if (browser_view()->ShouldShowWindowIcon()) {
     window_icon_ = new TabIconView(this);
     window_icon_->set_is_light(true);
     AddChildView(window_icon_);
     window_icon_->Update();
   }
 
   // Create incognito icon if necessary.
   UpdateAvatarInfo();
 
   // Frame painter handles layout of these buttons.
-  frame_painter_->Init(frame(), window_icon_, maximize_button_, close_button_);
+  frame_painter_->Init(frame(), window_icon_, size_button_, close_button_,
+                       size_button_behavior);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserNonClientFrameView overrides:
 
 gfx::Rect BrowserNonClientFrameViewAura::GetBoundsForTabStrip(
     views::View* tabstrip) const {
   if (!tabstrip)
     return gfx::Rect();
   int tabstrip_x =
       avatar_button() ?
       (avatar_button()->bounds().right() + kAvatarSideSpacing) :
       kTabstripLeftSpacing;
   int tabstrip_width =
-      maximize_button_->x() - kTabstripRightSpacing - tabstrip_x;
+      size_button_->x() - kTabstripRightSpacing - tabstrip_x;
   return gfx::Rect(tabstrip_x,
                    GetHorizontalTabStripVerticalOffset(false),
                    std::max(0, tabstrip_width),
                    tabstrip->GetPreferredSize().height());
 }
 
 int BrowserNonClientFrameViewAura::GetHorizontalTabStripVerticalOffset(
     bool force_restored) const {
   return NonClientTopBorderHeight(force_restored);
 }
@@ skipping 33 matching lines @@
   }
   return hit_test;
 }
 
 void BrowserNonClientFrameViewAura::GetWindowMask(const gfx::Size& size,
                                                   gfx::Path* window_mask) {
   // Aura does not use window masks.
 }
 
 void BrowserNonClientFrameViewAura::ResetWindowControls() {
-  maximize_button_->SetState(views::CustomButton::BS_NORMAL);
+  size_button_->SetState(views::CustomButton::BS_NORMAL);
   // The close button isn't affected by this constraint.
 }
 
 void BrowserNonClientFrameViewAura::UpdateWindowIcon() {
   if (window_icon_)
     window_icon_->SchedulePaint();
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // views::View overrides:
@@ skipping 58 matching lines @@
 
 gfx::Size BrowserNonClientFrameViewAura::GetMinimumSize() {
   return frame_painter_->GetMinimumSize(this);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // views::ButtonListener overrides:
 
 void BrowserNonClientFrameViewAura::ButtonPressed(views::Button* sender,
                                                   const views::Event& event) {
-  if (sender == maximize_button_) {
+  if (sender == size_button_) {
     // The maximize button may move out from under the cursor.
     ResetWindowControls();
-    if (frame()->IsMaximized())
+    if (size_button_minimizes_)
+      frame()->Minimize();
+    else if (frame()->IsMaximized())
       frame()->Restore();
     else
       frame()->Maximize();
     // |this| may be deleted - some windows delete their frames on maximize.
   } else if (sender == close_button_) {
     frame()->Close();
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ skipping 177 matching lines @@
 }
 
 SkBitmap* BrowserNonClientFrameViewAura::GetCustomBitmap(
     int bitmap_id,
     int fallback_bitmap_id) const {
   ui::ThemeProvider* tp = GetThemeProvider();
   if (tp->HasCustomImage(bitmap_id))
     return tp->GetBitmapNamed(bitmap_id);
   return tp->GetBitmapNamed(fallback_bitmap_id);
 }