Issue 9950035: Revert 129968 - Use gyp names in MIDL build rules rather than VS macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9950035: Revert 129968 - Use gyp names in MIDL build rules rather than VS macros. (Closed)

Created:
8 years, 8 months ago by tony

Modified:
8 years, 8 months ago

Reviewers:
scottmg1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 129968 - Use gyp names in MIDL build rules rather than VS macros. This broke the Google Chrome Win build: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/9711 In support of ninja/windows. DLLDataFileName changed to be uniquized too because in a target that has multiple idl files, they would all output to the same dlldata.c (which ninja quite reasonably doesn't like). Review URL: https://chromiumcodereview.appspot.com/9460048 TBR=scottmg@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130000

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	build/common.gypi	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 1 (0 generated)