Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 9460048: Use gyp names in MIDL build rules rather than VS macros (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use gyp names in MIDL build rules rather than VS macros. In support of ninja/windows. DLLDataFileName changed to be uniquized too because in a target that has multiple idl files, they would all output to the same dlldata.c (which ninja quite reasonably doesn't like). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129968

Patch Set 1 #

Patch Set 2 : fix dlldata name too #

Total comments: 1

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/common.gypi View 1 2 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
8 years, 8 months ago (2012-03-29 22:44:41 UTC) #1
Mark Mentovai
LGTM if intentional. https://chromiumcodereview.appspot.com/9460048/diff/3001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/9460048/diff/3001/build/common.gypi#newcode2839 build/common.gypi:2839: 'DLLDataFileName': '<(RULE_INPUT_NAME).dlldata.c', This is not equivalent ...
8 years, 8 months ago (2012-03-30 12:54:27 UTC) #2
scottmg
On 2012/03/30 12:54:27, Mark Mentovai wrote: > LGTM if intentional. > Thanks. Yes, intentional. Noted ...
8 years, 8 months ago (2012-03-30 19:01:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/9460048/3001
8 years, 8 months ago (2012-03-30 19:19:24 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-03-30 22:10:34 UTC) #5
Try job failure for 9460048-3001 (retry) on win_rel for steps "ui_tests,
browser_tests".
It's a second try, previously, steps "ui_tests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698