The first few short pkg:http examples

The first few short pkg:http examples

R=ajohnsen@google.com

Committed: e99fc67

[shailentuli, 2013-12-06 11:19:01]

The first installment of short examples showing use of pkg:http.

More to come, and the landing page on dartlang where these examples will be
shown will have short explanations accompanying each example. 

I have found developers find these kind of simple examples useful. Can you give
this a lookover for general content? 

- Shailen

[shailentuli, 2013-12-06 11:40:14]

Adding Soren. You both don't need to look at this I expect (whoever has time).
Thanks.

Shailen

[Anders Johnsen, 2013-12-06 11:53:27]

LGTM, nice examples :)

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/getting_response_content_in_binary_format.dart
(right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/getting_response_content_in_binary_format.dart:7:
var bytes = response.bodyBytes;
var -> List<int>

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/getting_response_content_in_binary_format.dart:9:
var base64 = CryptoUtils.bytesToBase64(bytes);
var -> String

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/handling_an_httprequest_error.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/handling_an_httprequest_error.dart:9:
handleFailure(SocketException e) {
Don't expect SocketException. In theory, it could also be HttpException. maybe
just say:

handleFailure(error) {
  ...
}

and remove dart:io import.

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/making_a_post_request.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/making_a_post_request.dart:5: http.post(url,
fields: {"name": "doodle", "color": "blue"}).then((response) {
This is posting specific fields. To match the test name, I think it should
simply post a string:

http.post(url, data: "some body")...

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File
recipes/dart_io/pkg_http/bin/making_multiple_requests_to_the_same_server.dart
(right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/making_multiple_requests_to_the_same_server.dart:6:
client.post('${url}post', fields: {"name": "doodle", "color": "blue"})
Why is this example using post?

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/reading_the_response_body.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/reading_the_response_body.dart:4:
http.read("http://httpbin.org/").then(print);
This is working due to the toString of a response returns the body. I think the
right way to show this is to actually extract the body/bodyBytes of the
response.

[shailentuli, 2013-12-06 18:00:17]

Committed patchset #1 manually as re99fc67 (presubmit successful).

[shailentuli, 2013-12-06 18:16:29]

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/getting_response_content_in_binary_format.dart
(right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/getting_response_content_in_binary_format.dart:7:
var bytes = response.bodyBytes;
On 2013/12/06 11:53:28, Anders Johnsen wrote:
> var -> List<int>

Done.

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/getting_response_content_in_binary_format.dart:9:
var base64 = CryptoUtils.bytesToBase64(bytes);
On 2013/12/06 11:53:28, Anders Johnsen wrote:
> var -> String

Done.

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/handling_an_httprequest_error.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/handling_an_httprequest_error.dart:9:
handleFailure(SocketException e) {
On 2013/12/06 11:53:28, Anders Johnsen wrote:
> Don't expect SocketException. In theory, it could also be HttpException. maybe
> just say:
> 
> handleFailure(error) {
>   ...
> }
> 
> and remove dart:io import.

Done.

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/making_a_post_request.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/making_a_post_request.dart:5: http.post(url,
fields: {"name": "doodle", "color": "blue"}).then((response) {
On 2013/12/06 11:53:28, Anders Johnsen wrote:
> This is posting specific fields. To match the test name, I think it should
> simply post a string:
> 
> http.post(url, data: "some body")...

Anders, there is no data arg for http.post(). I'm leaving this as is for now.

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File
recipes/dart_io/pkg_http/bin/making_multiple_requests_to_the_same_server.dart
(right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/making_multiple_requests_to_the_same_server.dart:6:
client.post('${url}post', fields: {"name": "doodle", "color": "blue"})
On 2013/12/06 11:53:28, Anders Johnsen wrote:
> Why is this example using post?

No particular reason except to show that you can do that. I've made all the
requests GET now.

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/reading_the_response_body.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/reading_the_response_body.dart:4:
http.read("http://httpbin.org/").then(print);
On 2013/12/06 11:53:28, Anders Johnsen wrote:
> This is working due to the toString of a response returns the body. I think
the
> right way to show this is to actually extract the body/bodyBytes of the
> response.

Anders, I'm showing the use of http.read() which returns a String, not a
http.Response object.

[Søren Gjesse, 2013-12-09 08:30:46]

lgtm, with a few comments/suggestions

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/adding_custom_headers.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/adding_custom_headers.dart:6: http.get(url, headers
: {'User-Agent': 'request'}).then((response) {
Shouldn't we put something like 'Dart/1.0 (My Dart client)' in the User-Agent
header? Or chose another header?

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/adding_custom_headers.dart:9:
print("${repo['name']}, "
Maybe add some label text as well, e.g. "Repository: ${repo['name']}: " ...

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/getting_the_response_headers.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/getting_the_response_headers.dart:9:
print(response.headers['access-control-allow-origin']);
Additional label text?

print("Access-Control-Allow-Origin:
${response.headers['access-control-allow-origin']}");

[shailentuli, 2013-12-11 04:07:51]

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/adding_custom_headers.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/adding_custom_headers.dart:6: http.get(url, headers
: {'User-Agent': 'request'}).then((response) {
On 2013/12/09 08:30:47, Søren Gjesse wrote:
> Shouldn't we put something like 'Dart/1.0 (My Dart client)' in the User-Agent
> header? Or chose another header?

Done.

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/adding_custom_headers.dart:9:
print("${repo['name']}, "
On 2013/12/09 08:30:47, Søren Gjesse wrote:
> Maybe add some label text as well, e.g. "Repository: ${repo['name']}: " ...

Added a little header explaining the categories.

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
File recipes/dart_io/pkg_http/bin/getting_the_response_headers.dart (right):

https://chromiumcodereview.appspot.com/99333012/diff/1/recipes/dart_io/pkg_ht...
recipes/dart_io/pkg_http/bin/getting_the_response_headers.dart:9:
print(response.headers['access-control-allow-origin']);
On 2013/12/09 08:30:47, Søren Gjesse wrote:
> Additional label text?
> 
> print("Access-Control-Allow-Origin:
> ${response.headers['access-control-allow-origin']}");

Added additional label text