Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 9931004: Merge 112364 - [chromium] Transfer wheel fling via WebCompositorInputHandlerClient (Closed)

Created:
8 years, 11 months ago by jamesr
Modified:
8 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 112364 - [chromium] Transfer wheel fling via WebCompositorInputHandlerClient https://bugs.webkit.org/show_bug.cgi?id=81740 Patch by James Robinson <jamesr@chromium.org>; on 2012-03-27 Reviewed by Adrienne Walker. Source/WebCore: Adds the ability to construct an in-progress PlatformGestureAnimation. * platform/ActivePlatformGestureAnimation.cpp: (WebCore::ActivePlatformGestureAnimation::create): (WebCore): (WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation): * platform/ActivePlatformGestureAnimation.h: (ActivePlatformGestureAnimation): * platform/TouchpadFlingPlatformGestureCurve.cpp: (WebCore::TouchpadFlingPlatformGestureCurve::create): (WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve): * platform/TouchpadFlingPlatformGestureCurve.h: (TouchpadFlingPlatformGestureCurve): Source/WebKit/chromium: Adds a path for transfering an active wheel fling animation out to the embedder from the compositor and back in to a WebViewImpl via the embedder. This is used when we start a wheel fling animation on the compositor thread but then hit a condition that we can't handle from the compositor, such as registered wheel event listeners or a scrollable area we can't handle. New tests added to WebCompositorInputHandlerTest for the transfering logic. * public/WebActiveWheelFlingParameters.h: Copied from Source/WebKit/chromium/public/WebCompositorInputHandlerClient.h. (WebKit): (WebActiveWheelFlingParameters): (WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters): * public/WebCompositorInputHandlerClient.h: (WebKit): (WebCompositorInputHandlerClient): (WebKit::WebCompositorInputHandlerClient::transferActiveWheelFlingAnimation): * public/WebView.h: (WebKit): (WebView): * src/WebCompositorInputHandlerImpl.cpp: (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): (WebKit::WebCompositorInputHandlerImpl::animate): (WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling): (WebKit::WebCompositorInputHandlerImpl::scrollBy): * src/WebCompositorInputHandlerImpl.h: (WebCore): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::transferActiveWheelFlingAnimation): (WebKit): * src/WebViewImpl.h: (WebViewImpl): * tests/WebCompositorInputHandlerImplTest.cpp: (WebKit::MockWebCompositorInputHandlerClient::MockWebCompositorInputHandlerClient): (MockWebCompositorInputHandlerClient): (WebKit::TEST): (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest): (WebKit::WebCompositorInputHandlerImplTest::~WebCompositorInputHandlerImplTest): (WebCompositorInputHandlerImplTest): (WebKit::TEST_F): (WebKit): TBR=commit-queue@webkit.org BUG=118779 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=112614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -110 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +21 lines, -0 lines 0 comments Download
M Source/WebCore/platform/ActivePlatformGestureAnimation.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/platform/ActivePlatformGestureAnimation.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +57 lines, -0 lines 0 comments Download
A + Source/WebKit/chromium/public/WebActiveWheelFlingParameters.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebKit/chromium/public/WebCompositorInputHandlerClient.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/public/WebView.h View 3 chunks +5 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.h View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp View 4 chunks +26 lines, -14 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 3 chunks +26 lines, -12 lines 0 comments Download
M Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp View 14 chunks +251 lines, -74 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years, 11 months ago (2012-03-30 00:12:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698