Refactored the CloudPolicyProvider so that it becomes initialized once and stays initialized.

chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

Index: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
index 1d11abb8dd167ca452d724bcbe727ce8d9ed977d..c89ff654a39510665c40a5c8bbc4899d03fa847f 100644
--- a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
@@ -133,6 +133,9 @@ class ExistingUserControllerTest : public CrosInProcessBrowserTest {
     EXPECT_CALL(*mock_cryptohome_library_, IsMounted())
         .Times(AnyNumber())
         .WillRepeatedly(Return(true));
+    EXPECT_CALL(*mock_cryptohome_library_, InstallAttributesIsReady())
+        .Times(AnyNumber())
+        .WillRepeatedly(Return(false));

[Mattias Nissler (ping if slow), 2012/03/30 08:48:46]

Why this?

[Joao da Silva, 2012/03/30 10:09:23]

Because the --device-management-url and --enable-device-policy flags were added
to InProcessBrowserTests. Initialization of device policy uses
CrosLibrary::Get(), but since it has been overridden with this mock, the mock
must be updated to expect this call.

 
     mock_login_utils_ = new MockLoginUtils();
     LoginUtils::Set(mock_login_utils_);