Refactored the CloudPolicyProvider so that it becomes initialized once and stays initialized.

chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "chrome/browser/chromeos/cros/cros_mock.h"
 #include "chrome/browser/chromeos/cros/cros_in_process_browser_test.h"
@@ skipping 115 matching lines @@
     EXPECT_CALL(*mock_session_manager_client, EmitLoginPromptReady())
         .Times(1);
     EXPECT_CALL(*mock_session_manager_client, RetrievePolicy(_))
         .Times(AnyNumber());
 
     cros_mock_->InitMockCryptohomeLibrary();
     mock_cryptohome_library_ = cros_mock_->mock_cryptohome_library();
     EXPECT_CALL(*mock_cryptohome_library_, IsMounted())
         .Times(AnyNumber())
         .WillRepeatedly(Return(true));
+    EXPECT_CALL(*mock_cryptohome_library_, InstallAttributesIsReady())
+        .Times(AnyNumber())
+        .WillRepeatedly(Return(false));

[Mattias Nissler (ping if slow), 2012/03/30 08:48:46]

Why this?

[Joao da Silva, 2012/03/30 10:09:23]

Because the --device-management-url and --enable-device-policy flags were added
to InProcessBrowserTests. Initialization of device policy uses
CrosLibrary::Get(), but since it has been overridden with this mock, the mock
must be updated to expect this call.

 
     mock_login_utils_ = new MockLoginUtils();
     LoginUtils::Set(mock_login_utils_);
     EXPECT_CALL(*mock_login_utils_, PrewarmAuthentication())
         .Times(AnyNumber());
     EXPECT_CALL(*mock_login_utils_, StopBackgroundFetchers())
         .Times(AnyNumber());
 
     mock_login_display_.reset(new MockLoginDisplay());
     mock_login_display_host_.reset(new MockLoginDisplayHost());
@@ skipping 134 matching lines @@
       .Times(1);
   EXPECT_CALL(*mock_login_display_.get(), OnFadeOut())
       .Times(1);
   EXPECT_CALL(*mock_login_display_host_.get(), OnCompleteLogin())
       .Times(1);
   existing_user_controller()->CompleteLogin(kNewUsername, kPassword);
   ui_test_utils::RunAllPendingInMessageLoop();
 }
 
 }  // namespace chromeos