Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 9909013: Use isKnown instead of !isUnknown: if the inputs conflict, don't return automatically, but use the f (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/nodes.dart
===================================================================
--- lib/compiler/implementation/ssa/nodes.dart (revision 5969)
+++ lib/compiler/implementation/ssa/nodes.dart (working copy)
@@ -1170,7 +1170,6 @@
toString() => 'invoke interceptor: ${element.name}';
accept(HVisitor visitor) => visitor.visitInvokeInterceptor(this);
-
String get builtinJsName() {
if (getter
&& name == const SourceString('length')
@@ -1314,7 +1313,7 @@
HType computeType() {
HType inputsType = computeInputsType();
- if (!inputsType.isUnknown()) return inputsType;
+ if (inputsType.isKnown()) return inputsType;
if (left.isNumber()) return HType.NUMBER;
return HType.UNKNOWN;
}
@@ -1346,7 +1345,7 @@
HType computeType() {
HType computedType = computeInputsType();
if (computedType.isConflicting() && left.isString()) return HType.STRING;
- if (!computedType.isUnknown()) return computedType;
+ if (computedType.isKnown()) return computedType;
if (left.isNumber()) return HType.NUMBER;
return HType.UNKNOWN;
}
@@ -1446,7 +1445,7 @@
HType computeType() {
HType inputsType = computeInputsType();
- if (!inputsType.isUnknown()) return inputsType;
+ if (inputsType.isKnown()) return inputsType;
if (left.isInteger()) return HType.INTEGER;
return HType.UNKNOWN;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698