Use isKnown instead of !isUnknown: if the inputs conflict, don't return automatically, but use the f

lib/compiler/implementation/ssa/nodes.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface HVisitor<R> {
   R visitAdd(HAdd node);
   R visitBitAnd(HBitAnd node);
   R visitBitNot(HBitNot node);
   R visitBitOr(HBitOr node);
   R visitBitXor(HBitXor node);
@@ skipping 1152 matching lines @@
   final bool getter;
 
   HInvokeInterceptor(Selector selector,
                      SourceString this.name,
                      bool this.getter,
                      List<HInstruction> inputs)
       : super(selector, inputs);
   toString() => 'invoke interceptor: ${element.name}';
   accept(HVisitor visitor) => visitor.visitInvokeInterceptor(this);
 
-  
   String get builtinJsName() {
     if (getter
         && name == const SourceString('length')
         && inputs[1].isStringOrArray()) {
       return 'length';
     } else if (name == const SourceString('add') && inputs[1].isArray()) {
       return 'push';
     } else if (name == const SourceString('removeLast')
                && inputs[1].isArray()) {
       return 'pop';
@@ skipping 123 matching lines @@
       setUseGvn();
     } else {
       setAllSideEffects();
     }
   }
 
   bool get builtin() => left.isNumber() && right.isNumber();
 
   HType computeType() {
     HType inputsType = computeInputsType();
-    if (!inputsType.isUnknown()) return inputsType;
+    if (inputsType.isKnown()) return inputsType;
     if (left.isNumber()) return HType.NUMBER;
     return HType.UNKNOWN;
   }
 
   HType computeDesiredInputType(HInstruction input) {
     // TODO(floitsch): we want the target to be a function.
     if (input == target) return HType.UNKNOWN;
     if (isNumber() || left.isNumber() || right.isNumber()) return HType.NUMBER;
     if (type.isUnknown()) return HType.NUMBER;
     return HType.UNKNOWN;
@@ skipping 11 matching lines @@
 
   bool get builtin() {
     return (left.isNumber() && right.isNumber())
             || (left.isString() && right.isString())
             || (left.isString() && right is HConstant);
   }
 
   HType computeType() {
     HType computedType = computeInputsType();
     if (computedType.isConflicting() && left.isString()) return HType.STRING;
-    if (!computedType.isUnknown()) return computedType;
+    if (computedType.isKnown()) return computedType;
     if (left.isNumber()) return HType.NUMBER;
     return HType.UNKNOWN;
   }
 
   bool hasExpectedType() => builtin || type.isUnknown() || left.isString();
 
   HType computeDesiredInputType(HInstruction input) {
     // TODO(floitsch): we want the target to be a function.
     if (input == target) return HType.UNKNOWN;
     if (isString() || left.isString()) {
@@ skipping 79 matching lines @@
 // TODO(floitsch): Should HBinaryArithmetic really be the super class of
 // HBinaryBitOp?
 class HBinaryBitOp extends HBinaryArithmetic {
   HBinaryBitOp(HStatic target, HInstruction left, HInstruction right)
       : super(target, left, right);
 
   bool get builtin() => left.isInteger() && right.isInteger();
 
   HType computeType() {
     HType inputsType = computeInputsType();
-    if (!inputsType.isUnknown()) return inputsType;
+    if (inputsType.isKnown()) return inputsType;
     if (left.isInteger()) return HType.INTEGER;
     return HType.UNKNOWN;
   }
 
   HType computeDesiredInputType(HInstruction input) {
     // TODO(floitsch): we want the target to be a function.
     if (input == target) return HType.UNKNOWN;
     return HType.INTEGER;
   }
 
@@ skipping 598 matching lines @@
 class HIfBlockInformation {
   final HIf branch;
   final SubGraph thenGraph;
   final SubGraph elseGraph;
   final HBasicBlock joinBlock;
   HIfBlockInformation(this.branch,
                       this.thenGraph,
                       this.elseGraph,
                       this.joinBlock);
 }