Issue 9866049: Pass CompletionCallbacks by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9866049: Pass CompletionCallbacks by reference (Closed)

Created:
8 years, 9 months ago by Tyler Breisacher (Chromium)

Modified:
8 years, 8 months ago

Reviewers:
yzshen1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pass CompletionCallbacks by reference CID=100006,100007 BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129994

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	ppapi/cpp/dev/video_decoder_dev.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	ppapi/cpp/dev/video_decoder_dev.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9866049/1

8 years, 9 months ago (2012-03-27 22:58:02 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-27 23:05:25 UTC) #4

Try job failure for 9866049-1 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages