Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 9864005: Pull WebCore IDL via DEPS into all.deps checkout. (Closed)

Created:
8 years, 9 months ago by vsm
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org, sra1, Jacob
Visibility:
Public.

Description

Pull WebCore IDL via DEPS into all.deps checkout. WebCore is the common subdirectory in WebKit containing IDLs we use to generate Dart DOM APIs. Note, this adds ~8000 files to a checkout, under third_party. This is a prereq towards generating dom/html APIs at build time. Committed: https://code.google.com/p/dart/source/detail?r=5856

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M DEPS View 2 chunks +5 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
vsm
8 years, 9 months ago (2012-03-26 22:09:41 UTC) #1
dgrove
lgtm
8 years, 9 months ago (2012-03-26 22:10:40 UTC) #2
Jacob
lgtm
8 years, 9 months ago (2012-03-26 22:10:58 UTC) #3
ngeoffray
Hi Vijay! You also need to update the svn:ignore property on third_party/WebCore, otherwise all bots ...
8 years, 9 months ago (2012-03-27 12:56:39 UTC) #4
Anton Muhin
8 years, 9 months ago (2012-03-27 15:06:40 UTC) #5
DBQ

https://chromiumcodereview.appspot.com/9864005/diff/1/DEPS
File DEPS (right):

https://chromiumcodereview.appspot.com/9864005/diff/1/DEPS#newcode10
DEPS:10: "webkit_url": "http://src.chromium.org/multivm/trunk/webkit",
should we checkout from our fork or from main WebCore?

Powered by Google App Engine
This is Rietveld 408576698