chrome/browser/ui/webui/net_internals/net_internals_ui.cc - Issue 9860044: Coverity: check null returns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 9860044: Coverity: check null returns. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

index 1787dd84a65e6a290341a01c150cb3747a59a023..16ef8e9770ef65c4dd46960f33022d33b53c8284 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

@@ -1269,8 +1269,9 @@ void NetInternalsMessageHandler::IOThreadImpl::OnGetHttpPipeliningStatus(

net::HttpNetworkSession* http_network_session =

GetHttpNetworkSession(context_getter_->GetURLRequestContext());

- Value* pipelined_conneciton_info =

- http_network_session->http_stream_factory()->PipelineInfoToValue();

+ Value* pipelined_conneciton_info = NULL;

eroman 2012/03/27 18:05:52 nit: can you fix the typo on connection_info?

kmadhusu 2012/03/27 18:19:04 Done.

+ if (http_network_session)

+ http_network_session->http_stream_factory()->PipelineInfoToValue();

eroman 2012/03/27 18:05:52 Need to assign to pipelined_connection_info or thi

kmadhusu 2012/03/27 18:19:04 oops. Forgot to assign it. Fixed.

status_dict->Set("pipelined_connection_info", pipelined_conneciton_info);

const net::HttpServerProperties& http_server_properties =

« no previous file with comments | « chrome/browser/policy/configuration_policy_handler.cc ('k') | no next file » | no next file with comments »