chrome/browser/policy/configuration_policy_handler.cc - Issue 9860044: Coverity: check null returns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_handler.cc

Issue 9860044: Coverity: check null returns. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/configuration_policy_handler.cc

diff --git a/chrome/browser/policy/configuration_policy_handler.cc b/chrome/browser/policy/configuration_policy_handler.cc

index 86611db1cbd0fe2d8a2367e0ed3961df3358539c..36ab22040bc5efcc44571688fb72deaa77c46511 100644

--- a/chrome/browser/policy/configuration_policy_handler.cc

+++ b/chrome/browser/policy/configuration_policy_handler.cc

@@ -741,7 +741,7 @@ void ProxyPolicyHandler::ApplyPolicySettings(const PolicyMap& policies,

break;

case ProxyPrefs::MODE_PAC_SCRIPT: {

std::string pac_url_string;

- if (pac_url->GetAsString(&pac_url_string)) {

+ if (pac_url && pac_url->GetAsString(&pac_url_string)) {

prefs->SetValue(prefs::kProxy,

ProxyConfigDictionary::CreatePacScript(pac_url_string, false));

} else {