Issue 9860028: Valgrind cleanliness, part 2: Delete lithium operand caches on exit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9860028: Valgrind cleanliness, part 2: Delete lithium operand caches on exit. (Closed)

Created:
8 years, 9 months ago by Sven Panne

Modified:
8 years, 9 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Valgrind cleanliness, part 2: Delete lithium operand caches on exit. This fixes 5 leaks, returning 1.6kB of lost memory. Shocking news: I've actually introduced a 2nd-order macro for myself. I guess I've been assimilated... ;-) Committed: https://code.google.com/p/v8/source/detail?r=11179

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments addressed #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -24 lines)			Patch
M	src/lithium.h	View	1	8 chunks	+22 lines, -10 lines	0 comments	Download
M	src/lithium.cc	View	1	1 chunk	+20 lines, -14 lines	0 comments	Download
M	src/v8.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM https://chromiumcodereview.appspot.com/9860028/diff/1/src/lithium.h File src/lithium.h (right): https://chromiumcodereview.appspot.com/9860028/diff/1/src/lithium.h#newcode64 src/lithium.h:64: bool IsStackSlot() const { return kind() == STACK_SLOT; ...

8 years, 9 months ago (2012-03-28 12:24:15 UTC) #2

Sven Panne

8 years, 9 months ago (2012-03-28 13:11:10 UTC) #3

Landing with the suggested additional change...

https://chromiumcodereview.appspot.com/9860028/diff/1/src/lithium.h
File src/lithium.h (right):

https://chromiumcodereview.appspot.com/9860028/diff/1/src/lithium.h#newcode64
src/lithium.h:64: bool IsStackSlot() const { return kind() == STACK_SLOT; }
On 2012/03/28 12:24:16, Erik Corry wrote:
> You could use your shiny new 2nd order macro here too!

Done.

Expand Messages | Collapse Messages