Valgrind cleanliness, part 2: Delete lithium operand caches on exit.

src/lithium.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 17 matching lines @@
 #ifndef V8_LITHIUM_H_
 #define V8_LITHIUM_H_
 
 #include "allocation.h"
 #include "hydrogen.h"
 #include "safepoint-table.h"
 
 namespace v8 {
 namespace internal {
 
+#define LITHIUM_OPERAND_LIST(V)          \
+  V(LConstantOperand, CONSTANT_OPERAND)  \
+  V(LStackSlot,       STACK_SLOT)        \
+  V(LDoubleStackSlot, DOUBLE_STACK_SLOT) \
+  V(LRegister,        REGISTER)          \
+  V(LDoubleRegister,  DOUBLE_REGISTER)
+
+
 class LOperand: public ZoneObject {
  public:
   enum Kind {
     INVALID,
     UNALLOCATED,
     CONSTANT_OPERAND,
     STACK_SLOT,
     DOUBLE_STACK_SLOT,
     REGISTER,
     DOUBLE_REGISTER,
     ARGUMENT
   };
 
   LOperand() : value_(KindField::encode(INVALID)) { }
 
   Kind kind() const { return KindField::decode(value_); }
   int index() const { return static_cast<int>(value_) >> kKindFieldWidth; }
   bool IsConstantOperand() const { return kind() == CONSTANT_OPERAND; }
   bool IsStackSlot() const { return kind() == STACK_SLOT; }

[Erik Corry, 2012/03/28 12:24:16]

You could use your shiny new 2nd order macro here too!

[Sven Panne, 2012/03/28 13:11:11]

Done.

   bool IsDoubleStackSlot() const { return kind() == DOUBLE_STACK_SLOT; }
   bool IsRegister() const { return kind() == REGISTER; }
   bool IsDoubleRegister() const { return kind() == DOUBLE_REGISTER; }
   bool IsArgument() const { return kind() == ARGUMENT; }
   bool IsUnallocated() const { return kind() == UNALLOCATED; }
   bool IsIgnored() const { return kind() == INVALID; }
   bool Equals(LOperand* other) const { return value_ == other->value_; }
 
   void PrintTo(StringStream* stream);
   void ConvertTo(Kind kind, int index) {
     value_ = KindField::encode(kind);
     value_ |= index << kKindFieldWidth;
     ASSERT(this->index() == index);
   }
 
-  // Calls SetUpCache() for each subclass. Don't forget to update this method
-  // if you add a new LOperand subclass.
+  // Calls SetUpCache()/TearDownCache() for each subclass.
   static void SetUpCaches();
+  static void TearDownCaches();
 
  protected:
   static const int kKindFieldWidth = 3;
   class KindField : public BitField<Kind, 0, kKindFieldWidth> { };
 
   LOperand(Kind kind, int index) { ConvertTo(kind, index); }
 
   unsigned value_;
 };
 
@@ skipping 173 matching lines @@
     if (index < kNumCachedOperands) return &cache[index];
     return new LConstantOperand(index);
   }
 
   static LConstantOperand* cast(LOperand* op) {
     ASSERT(op->IsConstantOperand());
     return reinterpret_cast<LConstantOperand*>(op);
   }
 
   static void SetUpCache();
+  static void TearDownCache();
 
  private:
   static const int kNumCachedOperands = 128;
   static LConstantOperand* cache;
 
   LConstantOperand() : LOperand() { }
   explicit LConstantOperand(int index) : LOperand(CONSTANT_OPERAND, index) { }
 };
 
 
@@ skipping 15 matching lines @@
     if (index < kNumCachedOperands) return &cache[index];
     return new LStackSlot(index);
   }
 
   static LStackSlot* cast(LOperand* op) {
     ASSERT(op->IsStackSlot());
     return reinterpret_cast<LStackSlot*>(op);
   }
 
   static void SetUpCache();
+  static void TearDownCache();
 
  private:
   static const int kNumCachedOperands = 128;
   static LStackSlot* cache;
 
   LStackSlot() : LOperand() { }
   explicit LStackSlot(int index) : LOperand(STACK_SLOT, index) { }
 };
 
 
 class LDoubleStackSlot: public LOperand {
  public:
   static LDoubleStackSlot* Create(int index) {
     ASSERT(index >= 0);
     if (index < kNumCachedOperands) return &cache[index];
     return new LDoubleStackSlot(index);
   }
 
   static LDoubleStackSlot* cast(LOperand* op) {
     ASSERT(op->IsStackSlot());
     return reinterpret_cast<LDoubleStackSlot*>(op);
   }
 
   static void SetUpCache();
+  static void TearDownCache();
 
  private:
   static const int kNumCachedOperands = 128;
   static LDoubleStackSlot* cache;
 
   LDoubleStackSlot() : LOperand() { }
   explicit LDoubleStackSlot(int index) : LOperand(DOUBLE_STACK_SLOT, index) { }
 };
 
 
 class LRegister: public LOperand {
  public:
   static LRegister* Create(int index) {
     ASSERT(index >= 0);
     if (index < kNumCachedOperands) return &cache[index];
     return new LRegister(index);
   }
 
   static LRegister* cast(LOperand* op) {
     ASSERT(op->IsRegister());
     return reinterpret_cast<LRegister*>(op);
   }
 
   static void SetUpCache();
+  static void TearDownCache();
 
  private:
   static const int kNumCachedOperands = 16;
   static LRegister* cache;
 
   LRegister() : LOperand() { }
   explicit LRegister(int index) : LOperand(REGISTER, index) { }
 };
 
 
 class LDoubleRegister: public LOperand {
  public:
   static LDoubleRegister* Create(int index) {
     ASSERT(index >= 0);
     if (index < kNumCachedOperands) return &cache[index];
     return new LDoubleRegister(index);
   }
 
   static LDoubleRegister* cast(LOperand* op) {
     ASSERT(op->IsDoubleRegister());
     return reinterpret_cast<LDoubleRegister*>(op);
   }
 
   static void SetUpCache();
+  static void TearDownCache();
 
  private:
   static const int kNumCachedOperands = 16;
   static LDoubleRegister* cache;
 
   LDoubleRegister() : LOperand() { }
   explicit LDoubleRegister(int index) : LOperand(DOUBLE_REGISTER, index) { }
 };
 
 
@@ skipping 218 matching lines @@
   ShallowIterator current_iterator_;
 };
 
 
 int ElementsKindToShiftSize(ElementsKind elements_kind);
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_LITHIUM_H_