Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: media/base/demuxer.h

Issue 9860027: Remove DemuxerFactory and URL parameter from Pipeline. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: added some todos Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/demuxer_factory.h » ('j') | media/base/filter_collection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/demuxer.h
diff --git a/media/base/demuxer.h b/media/base/demuxer.h
index 044df3d970584afa807cfbae63f465bea8a97ce4..7b17b77f8dbca5d7ee09101877274ddda380cd38 100644
--- a/media/base/demuxer.h
+++ b/media/base/demuxer.h
@@ -39,6 +39,9 @@ class MEDIA_EXPORT Demuxer
public:
Demuxer();
+ // Completes initialization of the demuxer.
+ virtual void Initialize(const PipelineStatusCB& status_cb) = 0;
acolwell GONE FROM CHROMIUM 2012/03/27 20:11:35 How about removing set_host() and adding DemuxerHo
scherkus (not reviewing) 2012/03/27 20:44:09 added a TODO w/ bug as I was planning on doing tha
+
// Sets the private member |host_|. This is the first method called by
// the DemuxerHost after a demuxer is created. The host holds a strong
// reference to the demuxer. The reference held by the host is guaranteed
@@ -76,6 +79,8 @@ class MEDIA_EXPORT Demuxer
// Returns true if the source is from a local file or stream (such as a
// webcam stream), false otherwise.
+ //
+ // TODO(scherkus): See http://crbug.com/120426 on why we should remove this.
virtual bool IsLocalSource() = 0;
// Returns true if seeking is possible; false otherwise.
« no previous file with comments | « no previous file | media/base/demuxer_factory.h » ('j') | media/base/filter_collection.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698